<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div>Hello,<br></div>
<div><br></div>
<div>Just one comment about your commit title/message:<br></div>
<div>- You should mention that it's a macos patch by prefixing your title with "macos: "<br></div>
<div>- You should use the imperative form: Made => Make<br></div>
<div>- Mention the track ticket in the commit message (and not the title) like "Fixes #19993"<br></div>
<div><br></div>
<div>cf. <a href="https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html">https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html</a><br></div>
<div><br></div>
<div>On Mon, Mar 19, 2018, at 12:02, Daksh Shah wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>Now the tooltips which are shown in the Normal View are same as the ones which are shown in Full-Screen View. Adapted the shorter version.<br></div>
<div>And also, changed the Normal View toolTip of "Fullscreen" to "Enter fullscreen"<br></div>
<div><br></div>
</div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
<p>Email had 1 attachment:<br></p><ul><li><div><code>0001-Fixed-19993-Made-toolTips-on-Full-Screen-consistent.patch</code><br></div>
<div> 5k (text/plain)<br></div>
</li></ul></blockquote><div><br></div>
</body>
</html>