<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><div class=""></div><div class=""><br class=""></div><div class="">Regards,</div><div class="">Luís</div><div><br class=""><blockquote type="cite" class=""><div class="">On 30 Apr 2018, at 07:55, Steve Lhomme <<a href="mailto:robux4@ycbcr.xyz" class="">robux4@ycbcr.xyz</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div text="#000000" bgcolor="#FFFFFF" class=""><p class="">Please post your patches inline, it's easier to comment</p><p class=""><br class="">
</p><p class="">+ if (deinterlace < -1 || deinterlace > 1)<br class="">
+ deinterlace = -1;<br class="">
To make it more clear what you're doing maybe check if the value
is neither 0 nor 1.</p><p class=""><br class="">
</p><p class="">+ module_config_t *config =
config_FindConfig("deinterlace-mode");<br class="">
This should be var_GetString</p><p class=""><br class="">
</p><p class="">+ && strcmp (psz_mode, "auto"))<br class="">
It seems that should go in another patch before this one.</p><p class=""><br class="">
</p><p class="">- var_SetInteger (p_mi, "deinterlace", 1);<br class="">
+ var_SetInteger (p_mi, "deinterlace", deinterlace);<br class="">
}<br class="">
else<br class="">
- var_SetInteger (p_mi, "deinterlace", 0);<br class="">
+ var_SetInteger (p_mi, "deinterlace", deinterlace);<br class="">
</p><p class="">In both cases of the else you do the same call. So don't do it in
the else.<br class="">
</p>
<br class="">
<div class="moz-cite-prefix">Le 28/04/2018 à 20:13, Luís Fernandes a
écrit :<br class="">
</div>
<blockquote type="cite" cite="mid:0CDA4F63-9E9E-4BD1-BB9C-9F8253B33E18@gmail.com" class="">
<pre wrap="" class="">Hi all,
I’ve reworked the patch to change the method signature, and thus break compatibility with 3.0.
I’ve added a \version annotation to the .h of the function, but I have no idea if I need to do anything else to signal that this is for libvlc4.
Please advice on what I need to add more for the patch to be accepted.
Some notes on the patch:
- I had to add "auto" because the default deinterlace-mode for VLCKit is normally "auto", so without it the mode would never get triggered
- default mode is "auto" (-1) - which seems to be the default mode for vlc as well
Regards,
Luís
</pre>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<br class="">
<pre wrap="" class="">
</pre>
<blockquote type="cite" class="">
<pre wrap="" class="">On 22 Apr 2018, at 11:13, Jean-Baptiste Kempf <a class="moz-txt-link-rfc2396E" href="mailto:jb@videolan.org"><jb@videolan.org></a> wrote:
Hello,
On Sun, 22 Apr 2018, at 09:37, Rémi Denis-Courmont wrote:
</pre>
<blockquote type="cite" class="">
<pre wrap="" class="">IMO, an API clean-up and thus an ABI break is well overdue in general, and
with that, I'd do 1. But that's just my own personal opinion.
</pre>
</blockquote>
<pre wrap="" class="">Yes. Break API and ABI for 4.0. libvlc6. Go ahead.
But if anyone breaks ABI for 3.0, I'll break his neck. (in a soft fashion) :D
--
Jean-Baptiste Kempf - President
+33 672 704 734
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a>
</pre>
</blockquote>
<pre wrap="" class=""></pre>
<br class="">
<fieldset class="mimeAttachmentHeader"></fieldset>
<br class="">
<pre wrap="" class="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
<br class="">
</div>
_______________________________________________<br class="">vlc-devel mailing list<br class="">To unsubscribe or modify your subscription options:<br class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="">https://mailman.videolan.org/listinfo/vlc-devel</a></div></blockquote></div><br class=""></div></body></html>