<div dir="ltr">Hi, <div><br></div><div>I have updated the patch, kindly have a look. Yes, you were right about it not making a lot of sense to set the description same as I found out that in the normal view, the tooltip was being set to title(NSAccessibilityTitleAttribute). But in FullScreen, it was being set to description. So I changed the setupButton function and now the tooltip is being set to the title rather than the description (For FS View as well)</div><div><br>I also updated some of the values for that. Let me know if any changes are needed :)<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 21, 2018 at 11:23 PM David Fuhrmann <<a href="mailto:david.fuhrmann@gmail.com">david.fuhrmann@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">HI Daksh,<div><br></div><div>See below.<br><div></div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><div><br><blockquote type="cite"><div>Am 21.03.2018 um 12:00 schrieb Daksh Shah <<a href="mailto:daksh17336@iiitd.ac.in" target="_blank">daksh17336@iiitd.ac.in</a>>:</div><br class="m_-813062079578191380Apple-interchange-newline"><div><div dir="ltr">Thanks for your feedback. Kindly have a look at the replies in-line<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 21, 2018 at 4:28 AM David Fuhrmann <<a href="mailto:david.fuhrmann@gmail.com" target="_blank">david.fuhrmann@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
- _NS("Go to next item"));<br>
+ _NS("Forward"));<br>
<br>
This looks very misleading. This button is about jumping to next item, not about forwarding the same item.</blockquote><div>I am sorry. I will fix that and change the toolTip to "Next" </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Just below, there is another button for "Seek forward“. So you should not choose a description which is too close to the other button (as its done in your proposal).<br></blockquote><div>By proposal you mean this patch right? </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
If you compare to the buttons descriptions in the main window: Please note that those buttons have different features, depending if only a back and forward button is shown, or if „next“ / „prev“ buttons are shown additionally.<br></blockquote><div>I understood that now. I think that it is another place where some enhancement can be done. When the two new buttons show up, the toolTips remain the same. And the functionalities change. This does not seem intuitive for new users. <br>The only reason I realized that was because you pointed it out.</div><div><br></div><div>Should I try to change this?</div></div></div></div></blockquote><div><br></div></div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><div><div>Sure, if you want to.</div></div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
- _NS("Go to the previous item"));<br>
+ _NS("Backward"));<br>
<br>
Same here.<br>
<br>
setupButton(_timeSlider,<br>
_NS("Position"),<br>
- _NS("Adjust the current playback position"));<br>
+ _NS("Position"));<br>
<br>
Are you sure choosing the same string for Accessibility title and accessibility description is the correct thing to do? I would rather assume one might leave the description blank if you actually have no description (but I’m just guessing here…)<br></blockquote><div>I could not understand properly. The title is what shows up in the toolTip. But is there a place where the description shows up? I kept it just in case it might be describing the button in some other place.</div><div>If not, I think we should remove it. </div></div></div></div></blockquote><div><br></div></div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><div>Your patch modifies the attribute NSAccessibilityDescriptionAttribute, mainly. Would be great if you can check what this is and where its used in detail, and if you can find any guidelines how it should be filled. (IIRC is has something to do if you use accessibility options like voice control or similar, but I do not remember details out of my head.)</div><div><br></div><div>Just from the naming of both attributes, I find it weird to have a „title“ and a „description“ with the same content.</div></div></div><div style="word-wrap:break-word;line-break:after-white-space"><div><div><br><blockquote type="cite"><div style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo;color:rgb(120,73,42)"><br></div></blockquote><blockquote type="cite"><div><div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
BR. David<br>
<br>
> Am 19.03.2018 um 12:02 schrieb Daksh Shah <<a href="mailto:daksh17336@iiitd.ac.in" target="_blank">daksh17336@iiitd.ac.in</a>>:<br>
><br>
> Now the tooltips which are shown in the Normal View are same as the ones which are shown in Full-Screen View. Adapted the shorter version.<br>
> And also, changed the Normal View toolTip of "Fullscreen" to "Enter fullscreen"<br>
><br>
> <0001-Fixed-19993-Made-toolTips-on-Full-Screen-consistent.patch>_______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div></div>
_______________________________________________<br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></div></blockquote></div><br></div></div>_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div></div></div>