<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div>On Fri, May 18, 2018, at 11:33, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>Le perjantaina 18. toukokuuta 2018, 10.36.29 EEST Steve Lhomme a écrit :<br></div>
<blockquote><blockquote><div>No. It is not using the same environment that is prone to errors.<br></div>
</blockquote><div><br></div>
<div>Exactly, so forcing the user to change the environment for each folder<br></div>
<div>one compiles in is prone to errors.<br></div>
</blockquote><div><br></div>
<div>We actively support prefixed cross-"tools" and subdir builds, so one can have<br></div>
<div>as many targets as one wants in a single shell/environment. You can also force<br></div>
<div>any variable you want to point to anything suitable for any target.<br></div>
</blockquote><div><br></div>
<div>That's one way of doing things. That is extremly incovenient when you deal with many branches that have different configure.ac/contribs.<br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div>But if the user proactively changes the environment before configure, then<br></div>
<div>that must be reproduced for make and any cached rerun of configure. Likewise,<br></div>
<div>any environment change within configure itself must be reflected in make. So<br></div>
<div>patching CC or CFLAGS in configure is fine. But patching PATH or<br></div>
<div>LD_LIBRARY_PATH is wrong.<br></div>
<div><br></div>
<div>Now assuming that you neither patch PATH before running configure, and<br></div>
<div>configure does not patch PATH either, I don't see the point of your patch...<br></div>
</blockquote><div><br></div>
<div>You don't see how running /usr/bin/protoc (in the PATH) instead of /path/to/vlc/extra/tools/bin/protoc can be a problem ?<br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div>--<br></div>
<div>レミ・デニ-クールモン<br></div>
<div><a href="http://www.remlab.net/">http://www.remlab.net/</a><br></div>
<div><br></div>
<div><br></div>
<div><br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</body>
</html>