<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">Yes and then I'd have complained that you broke stuff instead of having it fixed.<br><br><div class="gmail_quote">Le 24 mai 2018 13:36:11 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
On 2018-05-24 12:29 PM, Rémi Denis-Courmont wrote:<br>
<blockquote type="cite" cite="mid:F9D218F5-6813-481C-AAA3-D2F538B015E1@remlab.net">The CoC
says to discuss before applying a revert, which is not the same as
asking permission from the author. This is not a revert anyway;
your patch fixed DTV on systems without search.h. That fix is
still in place.<br>
</blockquote>
<br>
This is nitpicking. If I did a commit per file it would equal to 3
reverts.<br>
<br>
<blockquote type="cite" cite="mid:F9D218F5-6813-481C-AAA3-D2F538B015E1@remlab.net"><br>
<div class="gmail_quote">Le 24 mai 2018 09:58:57 GMT+03:00, Steve
Lhomme <a class="moz-txt-link-rfc2396E" href="mailto:robux4@ycbcr.xyz"><robux4@ycbcr.xyz></a> a écrit :
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<pre class="k9mail">On 2018-05-23 8:33 PM, Rémi Denis-Courmont wrote:
<blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> vlc | branch: master | Rémi Denis-Courmont <a class="moz-txt-link-rfc2396E" href="mailto:remi@remlab.net"><remi@remlab.net></a> | Wed May 23 20:53:35 2018 +0300| [eca2be7d7fb8a02f7a27f57bd49261eebd115dcb] | committer: Rémi Denis-Courmont
Remove harmful HAVE_SEARCH_H
This fixes building the keysym generator.
Regression from 3cea7a78999068f71972094e849f95c1591d3e3a.
</blockquote>
How can this be harmful ? If the file is not there it should not be used.
Can we revert changes without asking the original author ?
<blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">
<blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> <a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=eca2be7d7fb8a02f7a27f57bd49261eebd115dcb" moz-do-not-send="true">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=eca2be7d7fb8a02f7a27f57bd49261eebd115dcb</a>
</blockquote> ---
modules/services_discovery/pulse.c | 2 --
modules/services_discovery/udev.c | 2 --
modules/video_output/xcb/keysym.c | 2 --
3 files changed, 6 deletions(-)
diff --git a/modules/services_discovery/pulse.c b/modules/services_discovery/pulse.c
index 839fb6a6fd..03ad22561d 100644
--- a/modules/services_discovery/pulse.c
+++ b/modules/services_discovery/pulse.c
@@ -24,9 +24,7 @@
# include <config.h>
#endif
-#ifdef HAVE_SEARCH_H
#include <search.h>
-#endif
#include <assert.h>
#include <vlc_common.h>
diff --git a/modules/services_discovery/udev.c b/modules/services_discovery/udev.c
index 65cf7e267b..d297f4708d 100644
--- a/modules/services_discovery/udev.c
+++ b/modules/services_discovery/udev.c
@@ -25,9 +25,7 @@
#endif
#include <errno.h>
-#ifdef HAVE_SEARCH_H
#include <search.h>
-#endif
#include <poll.h>
#include <sys/stat.h>
#include <fcntl.h>
diff --git a/modules/video_output/xcb/keysym.c b/modules/video_output/xcb/keysym.c
index f131013154..ad4e31c8a7 100644
--- a/modules/video_output/xcb/keysym.c
+++ b/modules/video_output/xcb/keysym.c
@@ -25,9 +25,7 @@
#include <stdlib.h>
#include <inttypes.h>
#include <limits.h>
-#ifdef HAVE_SEARCH_H
#include <search.h>
-#endif
#include <assert.h>
struct keysym
<hr>
vlc-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:vlc-commits@videolan.org">vlc-commits@videolan.org</a>
<a href="https://mailman.videolan.org/listinfo/vlc-commits" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-commits</a>
</blockquote>
<hr>
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
</div>
<br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
excuser ma brièveté.
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
<br>
</blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>