<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 2018-05-24 1:21 PM, Rémi Denis-Courmont wrote:<br>
<blockquote type="cite"
cite="mid:648D1608-D9E3-44D0-8D77-E8310BE1E969@remlab.net">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
I don't know what you meam by that.<br>
<br>
As noted multiple times, and as is obvious from its source code,
keysym.c is to generate a build-time tool.<br>
</blockquote>
<br>
You never said it's built as a tool until now, hence my question. In
fact this file doesn't seem to be referenced in any makefile or
script. So there's a reason I have no idea how it's supposed to be
used.<br>
<br>
So the revert is OK for this file but not the other two.<br>
<br>
<blockquote type="cite"
cite="mid:648D1608-D9E3-44D0-8D77-E8310BE1E969@remlab.net"><br>
<div class="gmail_quote">Le 24 mai 2018 14:09:12 GMT+03:00, Steve
Lhomme <a class="moz-txt-link-rfc2396E" href="mailto:robux4@ycbcr.xyz"><robux4@ycbcr.xyz></a> a écrit :
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;"> On 2018-05-24 12:47 PM, Rémi
Denis-Courmont wrote:<br>
<blockquote type="cite"
cite="mid:517111DD-2792-4CF7-9BBC-8B0C4E7983EF@remlab.net">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
They have to do with this that config.h is meant for host
code (CC), not for build code (BUILDCC).<br>
</blockquote>
<br>
And what does modules/video_output/xcb/keysym.c have to do
with BUILDCC ? It's only used to build fourcc_gen.<br>
<br>
<blockquote type="cite"
cite="mid:517111DD-2792-4CF7-9BBC-8B0C4E7983EF@remlab.net"><br>
<div class="gmail_quote">Le 24 mai 2018 13:39:54 GMT+03:00,
Steve Lhomme <a class="moz-txt-link-rfc2396E"
href="mailto:robux4@ycbcr.xyz" moz-do-not-send="true"><robux4@ycbcr.xyz></a>
a écrit :
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;"> On 2018-05-24 12:31 PM, Rémi
Denis-Courmont wrote:<br>
<blockquote type="cite"
cite="mid:68930DAA-1464-4430-B459-DEAC76ED5585@remlab.net">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
Yes.<br>
<br>
Udev assumes a platform that always had search.h.<br>
<br>
Keysym needs search.h to build and since HAVE_SEARCH_H
is never defined in build tool source code, it failed
to build.<br>
</blockquote>
<br>
What do build tools have to do with this ? You modified
modules/video_output/xcb/keysym.c <br>
That file is missing a config.h include. That would be
an appropriate fix (and should be added nonetheless).<br>
<br>
The other 2 files include config.h before the
HAVE_SEARCH_H so shouldn't fail unless your system is
broken.<br>
<br>
<br>
<blockquote type="cite"
cite="mid:68930DAA-1464-4430-B459-DEAC76ED5585@remlab.net"><br>
<div class="gmail_quote">Le 24 mai 2018 13:03:59
GMT+03:00, Steve Lhomme <a
class="moz-txt-link-rfc2396E"
href="mailto:robux4@ycbcr.xyz"
moz-do-not-send="true"><robux4@ycbcr.xyz></a>
a écrit :
<blockquote class="gmail_quote" style="margin: 0pt
0pt 0pt 0.8ex; border-left: 1px solid rgb(204,
204, 204); padding-left: 1ex;">
<p>No.<br>
</p>
<br>
<div class="moz-cite-prefix">On 2018-05-24 11:59
AM, Rémi Denis-Courmont wrote:<br>
</div>
<blockquote type="cite"
cite="mid:495E894E-B963-49E7-99CF-415FC4D978BF@remlab.net">No.
You broke it by over-zealously patching code,
PulseAudio (useless), udev (useless) and the X
keysym generator (plain wrong), when only DTV
had a problem.<br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9
Mail. Veuillez excuser ma brièveté.
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
<br>
</blockquote>
</div>
<br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail.
Veuillez excuser ma brièveté.
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
<br>
</blockquote>
</div>
<br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail.
Veuillez excuser ma brièveté.
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
<br>
</blockquote>
</div>
<br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
excuser ma brièveté.
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
</blockquote>
<br>
</body>
</html>