<html><head></head><body>The CoC says to discuss before applying a revert, which is not the same as asking permission from the author. This is not a revert anyway; your patch fixed DTV on systems without search.h. That fix is still in place.<br><br><div class="gmail_quote">Le 24 mai 2018 09:58:57 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2018-05-23 8:33 PM, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> vlc | branch: master | Rémi Denis-Courmont <remi@remlab.net> | Wed May 23 20:53:35 2018 +0300| [eca2be7d7fb8a02f7a27f57bd49261eebd115dcb] | committer: Rémi Denis-Courmont<br><br> Remove harmful HAVE_SEARCH_H<br><br> This fixes building the keysym generator.<br> Regression from 3cea7a78999068f71972094e849f95c1591d3e3a.<br></blockquote><br>How can this be harmful ? If the file is not there it should not be used.<br><br>Can we revert changes without asking the original author ?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> <a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=eca2be7d7fb8a02f7a27f57bd49261eebd115dcb">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=eca2be7d7fb8a02f7a27f57bd49261eebd115dcb</a><br></blockquote> ---<br><br> modules/services_discovery/pulse.c | 2 --<br> modules/services_discovery/udev.c | 2 --<br> modules/video_output/xcb/keysym.c | 2 --<br> 3 files changed, 6 deletions(-)<br><br> diff --git a/modules/services_discovery/pulse.c b/modules/services_discovery/pulse.c<br> index 839fb6a6fd..03ad22561d 100644<br> --- a/modules/services_discovery/pulse.c<br> +++ b/modules/services_discovery/pulse.c<br> @@ -24,9 +24,7 @@<br> # include <config.h><br> #endif<br> <br> -#ifdef HAVE_SEARCH_H<br> #include <search.h><br> -#endif<br> #include <assert.h><br> <br> #include <vlc_common.h><br> diff --git a/modules/services_discovery/udev.c b/modules/services_discovery/udev.c<br> index 65cf7e267b..d297f4708d 100644<br> --- a/modules/services_discovery/udev.c<br> +++ b/modules/services_discovery/udev.c<br> @@ -25,9 +25,7 @@<br> #endif<br> <br> #include <errno.h><br> -#ifdef HAVE_SEARCH_H<br> #include <search.h><br> -#endif<br> #include <poll.h><br> #include <sys/stat.h><br> #include <fcntl.h><br> diff --git a/modules/video_output/xcb/keysym.c b/modules/video_output/xcb/keysym.c<br> index f131013154..ad4e31c8a7 100644<br> --- a/modules/video_output/xcb/keysym.c<br> +++ b/modules/video_output/xcb/keysym.c<br> @@ -25,9 +25,7 @@<br> #include <stdlib.h><br> #include <inttypes.h><br> #include <limits.h><br> -#ifdef HAVE_SEARCH_H<br> #include <search.h><br> -#endif<br> #include <assert.h><br> <br> struct keysym<br><br><hr><br> vlc-commits mailing list<br> vlc-commits@videolan.org<br> <a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br></blockquote><br><hr><br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>