<!doctype html><html><head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body>That is an argument for never using dialogs and errors in non-GUI code though.<br>
<br>
Merge this and forget it, and all the complaints about the error message will turn into complaints about VLC doing nothing.<br><br><div class="gmail_quote">Le 25 mai 2018 12:49:31 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div>
<div>On Fri, May 25, 2018, at 11:44, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>Did I mention that failing silently was probably not a good idea already?<br></div>
<div> <br></div>
<div> Oh yes.<br></div>
<div> <br></div>
<div> Did you explain why it is a good idea?<br></div>
</blockquote><div><br></div>
<div>Because a module should never display any error dialogs. You can't know if the failing module is the last one to be probed. What happen if an other module succeed to open an encoder that failed with ffmpeg ?<br></div>
<div><br></div>
<blockquote type="cite"><div> <br></div>
<div> Oh no.<br></div>
<div><br></div>
<div defang_data-gmailquote="yes"><div>Le 25 mai 2018 12:35:51 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div><br></div>
<div>On Fri, May 25, 2018, at 11:25, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>I DO NOT KNOW what is the problem with this warning IN RECENT TIMES. Ergo, I do not know what is the proper solution either.<br></div>
</blockquote><div><br></div>
<div>The problem is that this warning is only relevant to Linux distributions. Why should we display such warning on macOS/Windows where Videolan, is the one doing the full VLC package (with ffmpeg built from our contribs). Therefore, the error message is wrong, since this is indeed "an error inside VLC media player" in that case.<br></div>
<div><br></div>
<div>I don't know what is the proper solution, but limiting this to only __linux__ seems to be a decent solution for now.<br></div>
<div><br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div>And it does not seem that you do either, or then I wonder why you did not explain it.<br></div>
<div><br></div>
<div><div>Le 25 mai 2018 12:11:35 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div>
<blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div><br></div>
<div>On Fri, May 25, 2018, at 11:05, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>No and I already explained why.<br></div>
</blockquote><div><br></div>
<div>I still don't get the reason at all.<br></div>
<div><br></div>
<div>Packages and distributions are only for LINUX and *BSD, maybe OS/2 ?<br></div>
<div>Maybe the if defined(__linux__) is not enough ? Should I add ^^ ?<br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div><div>Le 25 mai 2018 11:56:21 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div>
<blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div><br></div>
<div>On Fri, May 25, 2018, at 10:53, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>This is not simplifying. This is removing. It is even more confusing with this patch. Nack.<br></div>
</blockquote><div><br></div>
<div>Yes this is simplifying. Do you expect that an normal VLC users knowing what is a Libav/FFmeg packager ?<br></div>
<div><br></div>
<div>If you disagree with this patch, we need to do it only for linux. This no such thing as packager on every other OSes (specially since VideoLAN is packaging VLC for others OS/ports).<br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div><div>Le 25 mai 2018 11:19:14 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div>
<blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre><div>And simplify the error message.<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>Since we can't assume that all codecs have encoders.<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>---<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div> modules/codec/avcodec/encoder.c | 21 +--------------------<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div> 1 file changed, 1 insertion(+), 20 deletions(-)<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div><br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>diff --git a/modules/codec/avcodec/encoder.c b/modules/codec/avcodec/encoder.c<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>index 87fff6d3c7..7bd20f9e89 100644<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>--- a/modules/codec/avcodec/encoder.c<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>+++ b/modules/codec/avcodec/encoder.c<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>@@ -360,26 +360,7 @@ int InitVideoEnc( vlc_object_t *p_this )<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div> p_codec = avcodec_find_encoder( i_codec_id );<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div> if( !p_codec )<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div> {<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>- msg_Err( p_enc, "cannot find encoder %s\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"*** Your Libav/FFmpeg installation is crippled. ***\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"*** Please check with your Libav/FFmpeg packager. ***\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"*** This is NOT a VLC media player issue. ***", psz_namecodec );<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-#if !defined(_WIN32)<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>- vlc_dialog_display_error( p_enc, _("Streaming / Transcoding failed"), _(<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-/* I have had enough of all these MPEG-3 transcoding bug reports.<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>- * Downstream packager, you had better not patch this out, or I will be really<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>- * annoyed. Think about it - you don't want to fork the VLC translation files,<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>- * do you? -- Courmisch, 2008-10-22 */<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"It seems your Libav/FFmpeg (libavcodec) installation lacks the following encoder:\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"%s.\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"If you don't know how to fix this, ask for support from your distribution.\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"This is not an error inside VLC media player.\n"<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-"Do not contact the VideoLAN project about this issue.\n"),<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>- psz_namecodec );<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-#endif<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>-<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>+ msg_Err( p_enc, "cannot find encoder %s\n", psz_namecodec );<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div> return VLC_EGENERIC;<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div> } <br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
<div>
<br></div>
</pre></blockquote></div>
<div><br></div>
<div>--<br></div>
<div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div>
<div><br></div>
<div>--<br></div>
<div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div>
<div><br></div>
<div>--<br></div>
<div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div>
<div><br></div>
<div>--<br></div>
<div> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>