<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    On 2018-05-25 11:11 AM, Rémi Denis-Courmont wrote:<br>
    <blockquote type="cite"
      cite="mid:0C7E5B78-E0F3-4AFA-B7C7-639AD3271BAB@remlab.net">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      There are many new patch versions because *some* people (Videolabs
      newbies?) do take review comments into account, and because some
      other people take the easy 5 minutes work feedback into account
      and royally ignore the rest.<br>
    </blockquote>
    <br>
    Do you have examples of code being pushed despite disagreeing
    reviews ?<br>
    <br>
    <blockquote type="cite"
      cite="mid:0C7E5B78-E0F3-4AFA-B7C7-639AD3271BAB@remlab.net">
      <br>
      AFAIR the submission process states that one must either address
      *all* review comments - either in code or in explaining why the
      reviewer is wrong.<br>
      <br>
      <div class="gmail_quote">Le 25 mai 2018 12:03:59 GMT+03:00, Steve
        Lhomme <a class="moz-txt-link-rfc2396E" href="mailto:robux4@ycbcr.xyz"><robux4@ycbcr.xyz></a> a écrit :
        <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
          0.8ex; border-left: 1px solid rgb(204, 204, 204);
          padding-left: 1ex;"> On 2018-05-25 11:01 AM, Rémi
          Denis-Courmont wrote:<br>
          <blockquote type="cite"
            cite="mid:5CBC9F55-35FF-4225-AF37-64EBB039CF2A@remlab.net">
            <title></title>
            <style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
            And that's why I am fed up with explaining things. Because
            the reviewee doesn't give a damn and just ignores most of
            the explanation.<br>
            <br>
            In other words, all that talk about me being too terse from
            a few people here was just convenient excuse, posturing.
            People just want a rubber stamp insteaf of a review.<br>
          </blockquote>
          <br>
          Given the amount of "v2" patches on the list I don't think
          this is the case.<br>
          <br>
          <blockquote type="cite"
            cite="mid:5CBC9F55-35FF-4225-AF37-64EBB039CF2A@remlab.net"><br>
            <div class="gmail_quote">Le 25 mai 2018 11:29:58 GMT+03:00,
              Thomas Guillem <a class="moz-txt-link-rfc2396E"
                href="mailto:thomas@gllm.fr" moz-do-not-send="true"><thomas@gllm.fr></a>
              a écrit :
              <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
                0.8ex; border-left: 1px solid rgb(204, 204, 204);
                padding-left: 1ex;">
                <div><br>
                </div>
                <div>On Fri, May 25, 2018, at 10:24, Rémi Denis-Courmont
                  wrote:<br>
                </div>
                <blockquote type="cite">
                  <div>Err, how about stepping back for once, and
                    pondering why this message has become such a
                    problem? It has been there for years, with its
                    misleading wording, without causing much fuss until
                    recently.<br>
                  </div>
                </blockquote>
                <div><br>
                </div>
                <div>This was done in 2008 because of all the MPEG-3
                  encoders missing due to packagers in some Linux
                  distributions.<br>
                  I really don't think this issue is still relevant 10
                  years later. Besides, I found the comment and error
                  message a little bit aggressive.<br>
                </div>
                <div><br>
                </div>
                <blockquote type="cite">
                  <div> <br>
                  </div>
                  <div> This is a big dark orange flag that something
                    went wrong somewhere. Best guesses would be the
                    transcode plugin or the sout wizard.<br>
                  </div>
                  <div> <br>
                  </div>
                  <div> And even if it turns out that there are no
                    regression, I don't think that failing silently is a
                    good idea.<br>
                  </div>
                  <div><br>
                  </div>
                  <div defang_data-gmailquote="yes">
                    <div>Le 25 mai 2018 11:12:55 GMT+03:00, Thomas
                      Guillem <a class="moz-txt-link-rfc2396E"
                        href="mailto:thomas@gllm.fr"
                        moz-do-not-send="true"><thomas@gllm.fr></a>
                      a écrit :<br>
                    </div>
                    <blockquote defang_data-gmailquote="yes"
style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204,
                      204,
                      204);border-left-style:solid;border-left-width:1px;padding-left:1ex;">
                      <div>So we should remove the whole dialog and
                        simplify the error message.<br>
                      </div>
                      <div><br>
                      </div>
                      <div>On Fri, May 25, 2018, at 10:11, Rémi
                        Denis-Courmont wrote:<br>
                      </div>
                      <blockquote type="cite">
                        <div>Please stop this nonsense already. This is
                          gping nowhere.<br>
                        </div>
                        <div><br>
                        </div>
                        <div>The problem is not what OS this is relevant
                          on (and the answer to that is not even
                          "Linux"). The problem is that this code
                          wrongly assumes that all know codecs have an
                          encoder, and in all settings.<br>
                        </div>
                        <div><br>
                        </div>
                        <div>
                          <div>Le 25 mai 2018 10:18:57 GMT+03:00, Thomas
                            Guillem <a class="moz-txt-link-rfc2396E"
                              href="mailto:thomas@gllm.fr"
                              moz-do-not-send="true"><thomas@gllm.fr></a>
                            a écrit :<br>
                          </div>
                          <blockquote
style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204,
                            204,
                            204);border-left-style:solid;border-left-width:1px;padding-left:1ex;">
                            <pre><div>This error is only relevant on linux and it's really not needed for
</div>
<div>

</div>
<div>iOS/macOS/Android.
</div>
<div>

</div>
<div>---
</div>
<div>

</div>
<div> modules/codec/avcodec/encoder.c | 2 +-
</div>
<div>

</div>
<div> 1 file changed, 1 insertion(+), 1 deletion(-)
</div>
<div>

</div>
<div>
</div>
<div>

</div>
<div>diff --git a/modules/codec/avcodec/encoder.c b/modules/codec/avcodec/encoder.c
</div>
<div>

</div>
<div>index 87fff6d3c7..761da1a893 100644
</div>
<div>

</div>
<div>--- a/modules/codec/avcodec/encoder.c
</div>
<div>

</div>
<div>+++ b/modules/codec/avcodec/encoder.c
</div>
<div>

</div>
<div>@@ -365,7 +365,7 @@ int InitVideoEnc( vlc_object_t *p_this )
</div>
<div>

</div>
<div> "*** Please check with your Libav/FFmpeg packager. ***\n"
</div>
<div>

</div>
<div> "*** This is NOT a VLC media player issue.   ***", psz_namecodec );
</div>
<div>

</div>
<div> 
</div>
<div>

</div>
<div>-#if !defined(_WIN32)
</div>
<div>

</div>
<div>+#if defined(__linux__)
</div>
<div>

</div>
<div>         vlc_dialog_display_error( p_enc, _("Streaming / Transcoding failed"), _(
</div>
<div>

</div>
<div> /* I have had enough of all these MPEG-3 transcoding bug reports.
</div>
<div>

</div>
<div>  * Downstream packager, you had better not patch this out, or I will be really
</div>
<div>

</div>
</pre>
                          </blockquote>
                        </div>
                        <div><br>
                        </div>
                        <div>--<br>
                        </div>
                        <div>Envoyé de mon appareil Android avec
                          Courriel K-9 Mail. Veuillez excuser ma
                          brièveté. <br>
                        </div>
                        <div><u>_______________________________________________</u><br>
                        </div>
                        <div>vlc-devel mailing list<br>
                        </div>
                        <div>To unsubscribe or modify your subscription
                          options:<br>
                        </div>
                        <div><a
                            href="https://mailman.videolan.org/listinfo/vlc-devel"
                            moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
                        </div>
                      </blockquote>
                      <div><br>
                      </div>
                    </blockquote>
                  </div>
                  <div><br>
                  </div>
                  <div>--<br>
                  </div>
                  <div> Envoyé de mon appareil Android avec Courriel K-9
                    Mail. Veuillez excuser ma brièveté. <br>
                  </div>
                  <div><u>_______________________________________________</u><br>
                  </div>
                  <div>vlc-devel mailing list<br>
                  </div>
                  <div>To unsubscribe or modify your subscription
                    options:<br>
                  </div>
                  <div><a
                      href="https://mailman.videolan.org/listinfo/vlc-devel"
                      moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
                  </div>
                </blockquote>
                <div><br>
                </div>
              </blockquote>
            </div>
            <br>
            -- <br>
            Envoyé de mon appareil Android avec Courriel K-9 Mail.
            Veuillez excuser ma brièveté.
            <!--'"--><br>
            <fieldset class="mimeAttachmentHeader"></fieldset>
            <br>
            <pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
          </blockquote>
          <br>
        </blockquote>
      </div>
      <br>
      -- <br>
      Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
      excuser ma brièveté.
      <!--'"--><br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
    </blockquote>
    <br>
  </body>
</html>