<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    On 2018-05-25 12:08 PM, Rémi Denis-Courmont wrote:<br>
    <blockquote type="cite"
      cite="mid:A27F03F7-C245-47C1-9A45-F2B304455567@remlab.net">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      Don't register dialogs with LibVLC if you don't want dialogs. I
      agree that LibVLC should never raise dialogs by the way. It was
      not me who added the API in question.<br>
    </blockquote>
    <br>
    It is convenient when using Chromecast to tell the host when a
    costly transcoding is going to happen.<br>
    <br>
    Dialogs are already optional as you mentioned.<br>
    <br>
    <blockquote type="cite"
      cite="mid:A27F03F7-C245-47C1-9A45-F2B304455567@remlab.net"><br>
      <div class="gmail_quote">Le 25 mai 2018 12:39:12 GMT+03:00, Steve
        Lhomme <a class="moz-txt-link-rfc2396E" href="mailto:robux4@ycbcr.xyz"><robux4@ycbcr.xyz></a> a écrit :
        <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
          0.8ex; border-left: 1px solid rgb(204, 204, 204);
          padding-left: 1ex;"> On 2018-05-25 11:35 AM, Thomas Guillem
          wrote:<br>
          <blockquote type="cite"
cite="mid:1527240951.1855706.1384755464.7F98351D@webmail.messagingengine.com">
            <title></title>
            <style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
            <div><br>
            </div>
            <div>On Fri, May 25, 2018, at 11:25, Rémi Denis-Courmont
              wrote:<br>
            </div>
            <blockquote type="cite">
              <div>I DO NOT KNOW what is the problem with this warning
                IN RECENT TIMES. Ergo, I do not know what is the proper
                solution either.<br>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>The problem is that this warning is only relevant to
              Linux distributions. Why should we display such warning on
              macOS/Windows where  Videolan,  is the one doing the full
              VLC package (with ffmpeg built from our contribs).
              Therefore, the error message is wrong, since this is
              indeed "an error inside VLC media player" in that case.<br>
            </div>
          </blockquote>
          <br>
          This code can also be used in libvlc without vlc. In this case
          it makes even less sense.<br>
          <br>
          <blockquote type="cite"
cite="mid:1527240951.1855706.1384755464.7F98351D@webmail.messagingengine.com">
            <div><br>
            </div>
            <div>I don't know what is the proper solution, but limiting
              this to only __linux__ seems to be a decent solution for
              now.<br>
            </div>
            <div><br>
            </div>
            <div><br>
            </div>
            <blockquote type="cite">
              <div> <br>
              </div>
              <div> And it does not seem that you do either, or then I
                wonder why you did not explain it.<br>
              </div>
              <div><br>
              </div>
              <div defang_data-gmailquote="yes">
                <div>Le 25 mai 2018 12:11:35 GMT+03:00, Thomas Guillem <a
                    class="moz-txt-link-rfc2396E"
                    href="mailto:thomas@gllm.fr" moz-do-not-send="true"><thomas@gllm.fr></a>
                  a écrit :<br>
                </div>
                <blockquote defang_data-gmailquote="yes"
style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204,
                  204,
                  204);border-left-style:solid;border-left-width:1px;padding-left:1ex;">
                  <div><br>
                  </div>
                  <div>On Fri, May 25, 2018, at 11:05, Rémi
                    Denis-Courmont wrote:<br>
                  </div>
                  <blockquote type="cite">
                    <div>No and I already explained why.<br>
                    </div>
                  </blockquote>
                  <div><br>
                  </div>
                  <div>I still don't get the reason at all.<br>
                  </div>
                  <div><br>
                  </div>
                  <div>Packages and distributions are only for LINUX and
                    *BSD, maybe OS/2 ?<br>
                  </div>
                  <div>Maybe the if defined(__linux__) is not enough ?
                    Should I add ^^ ?<br>
                  </div>
                  <div><br>
                  </div>
                  <blockquote type="cite">
                    <div><br>
                    </div>
                    <div>
                      <div>Le 25 mai 2018 11:56:21 GMT+03:00, Thomas
                        Guillem <a class="moz-txt-link-rfc2396E"
                          href="mailto:thomas@gllm.fr"
                          moz-do-not-send="true"><thomas@gllm.fr></a>
                        a écrit :<br>
                      </div>
                      <blockquote
style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204,
                        204,
                        204);border-left-style:solid;border-left-width:1px;padding-left:1ex;">
                        <div><br>
                        </div>
                        <div>On Fri, May 25, 2018, at 10:53, Rémi
                          Denis-Courmont wrote:<br>
                        </div>
                        <blockquote type="cite">
                          <div>This is not simplifying. This is
                            removing. It is even more confusing with
                            this patch. Nack.<br>
                          </div>
                        </blockquote>
                        <div><br>
                        </div>
                        <div>Yes this is simplifying. Do you expect that
                          an normal VLC users knowing what is a
                          Libav/FFmeg packager ?<br>
                        </div>
                        <div><br>
                        </div>
                        <div>If you disagree with this patch, we need to
                          do it only for linux. This no such thing as
                          packager on every other OSes (specially since
                          VideoLAN is packaging VLC for others
                          OS/ports).<br>
                        </div>
                        <div><br>
                        </div>
                        <blockquote type="cite">
                          <div><br>
                          </div>
                          <div>
                            <div>Le 25 mai 2018 11:19:14 GMT+03:00,
                              Thomas Guillem <a
                                class="moz-txt-link-rfc2396E"
                                href="mailto:thomas@gllm.fr"
                                moz-do-not-send="true"><thomas@gllm.fr></a>
                              a écrit :<br>
                            </div>
                            <blockquote
style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204,
                              204,
                              204);border-left-style:solid;border-left-width:1px;padding-left:1ex;">
                              <pre><div>And simplify the error message.
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>Since we can't assume that all codecs have encoders.
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>---
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div> modules/codec/avcodec/encoder.c | 21 +--------------------
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div> 1 file changed, 1 insertion(+), 20 deletions(-)
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>diff --git a/modules/codec/avcodec/encoder.c b/modules/codec/avcodec/encoder.c
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>index 87fff6d3c7..7bd20f9e89 100644
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>--- a/modules/codec/avcodec/encoder.c
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>+++ b/modules/codec/avcodec/encoder.c
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>@@ -360,26 +360,7 @@ int InitVideoEnc( vlc_object_t *p_this )
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>         p_codec = avcodec_find_encoder( i_codec_id );
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>     if( !p_codec )
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>     {
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-        msg_Err( p_enc, "cannot find encoder %s\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"*** Your Libav/FFmpeg installation is crippled.   ***\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"*** Please check with your Libav/FFmpeg packager. ***\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"*** This is NOT a VLC media player issue.   ***", psz_namecodec );
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-#if !defined(_WIN32)
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-        vlc_dialog_display_error( p_enc, _("Streaming / Transcoding failed"), _(
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-/* I have had enough of all these MPEG-3 transcoding bug reports.
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>- * Downstream packager, you had better not patch this out, or I will be really
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>- * annoyed. Think about it - you don't want to fork the VLC translation files,
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>- * do you? -- Courmisch, 2008-10-22 */
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"It seems your Libav/FFmpeg (libavcodec) installation lacks the following encoder:\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"%s.\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"If you don't know how to fix this, ask for support from your distribution.\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"This is not an error inside VLC media player.\n"
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-"Do not contact the VideoLAN project about this issue.\n"),
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-            psz_namecodec );
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-#endif
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>-
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>+        msg_Err( p_enc, "cannot find encoder %s\n", psz_namecodec );
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>         return VLC_EGENERIC;
</div>
<div>

</div>
<div>

</div>
<div>

</div>
<div>     } 
</div>
<div>

</div>
<div>

</div>
<div>

</div>
</pre>
                            </blockquote>
                          </div>
                          <div><br>
                          </div>
                          <div>--<br>
                          </div>
                          <div>Envoyé de mon appareil Android avec
                            Courriel K-9 Mail. Veuillez excuser ma
                            brièveté. <br>
                          </div>
                          <div><u>_______________________________________________</u><br>
                          </div>
                          <div>vlc-devel mailing list<br>
                          </div>
                          <div>To unsubscribe or modify your
                            subscription options:<br>
                          </div>
                          <div><a
                              href="https://mailman.videolan.org/listinfo/vlc-devel"
                              moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
                          </div>
                        </blockquote>
                        <div><br>
                        </div>
                      </blockquote>
                    </div>
                    <div><br>
                    </div>
                    <div>--<br>
                    </div>
                    <div>Envoyé de mon appareil Android avec Courriel
                      K-9 Mail. Veuillez excuser ma brièveté. <br>
                    </div>
                    <div><u>_______________________________________________</u><br>
                    </div>
                    <div>vlc-devel mailing list<br>
                    </div>
                    <div>To unsubscribe or modify your subscription
                      options:<br>
                    </div>
                    <div><a
                        href="https://mailman.videolan.org/listinfo/vlc-devel"
                        moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
                    </div>
                  </blockquote>
                  <div><br>
                  </div>
                </blockquote>
              </div>
              <div><br>
              </div>
              <div>--<br>
              </div>
              <div> Envoyé de mon appareil Android avec Courriel K-9
                Mail. Veuillez excuser ma brièveté. <br>
              </div>
              <div><u>_______________________________________________</u><br>
              </div>
              <div>vlc-devel mailing list<br>
              </div>
              <div>To unsubscribe or modify your subscription options:<br>
              </div>
              <div><a
                  href="https://mailman.videolan.org/listinfo/vlc-devel"
                  moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
              </div>
            </blockquote>
            <div><br>
            </div>
            <!--'"--><br>
            <fieldset class="mimeAttachmentHeader"></fieldset>
            <br>
            <pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel" moz-do-not-send="true">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
          </blockquote>
          <br>
        </blockquote>
      </div>
      <br>
      -- <br>
      Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
      excuser ma brièveté.
      <!--'"--><br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
<a class="moz-txt-link-freetext" href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre>
    </blockquote>
    <br>
  </body>
</html>