<html xmlns="http://www.w3.org/1999/xhtml"><head>
<title></title>
</head>
<body>This change just deduplicates the size event handling. The result is the same as before: send a display size change control. The only potential difference that comes to mind is the timing, which might be faster.<br>
<br>
Regardless, sending an event back to your self (through the core) is schizophrenic. There are no reason to call this in a plug-in with windowing.<br>
<br>
Of course, besides potential races within the display plug-in, this also races against the size events of the window provider. But that potential bug is not new, it is also in 3.0.1<br><br><div class="gmail_quote">Le 26 mai 2018 06:45:38 GMT+02:00, robux4@ycbcr.xyz a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div name="messageBodySection"><font color="#333333">This commit broke Windows playback.<br>
<br>
It doesn't seem to be enough to revert just this one. The define it relied on is gone too.</font></div>
<div name="messageReplySection"><br>
On 20 May 2018 at 19:52 +0200, Rémi Denis-Courmont <git@videolan.org>, wrote:<br>
<blockquote type="cite">vlc | branch: master | Rémi Denis-Courmont <remi@remlab.net> | Fri May 18 21:18:47 2018 +0300| [a4942d980a4d92ab8819b019d47804d43410efb2] | committer: Rémi Denis-Courmont<br>
<br>
display: reroute and deprecate display size event<br>
<br>
The window size should be determined by the window provider, not the<br>
display plugin.<br>
<br>
<blockquote type="cite">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a4942d980a4d92ab8819b019d47804d43410efb2<br></blockquote>
---<br>
<br>
include/vlc_vout_display.h | 7 +++++--<br>
1 file changed, 5 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/include/vlc_vout_display.h b/include/vlc_vout_display.h<br>
index edc1238aee..e70a20ad8e 100644<br>
--- a/include/vlc_vout_display.h<br>
+++ b/include/vlc_vout_display.h<br>
@@ -313,10 +313,13 @@ static inline void vout_display_SendEvent(vout_display_t *vd, int query, ...)<br>
va_end(args);<br>
}<br>
<br>
-static inline void vout_display_SendEventDisplaySize(vout_display_t *vd, int width, int height)<br>
+VLC_DEPRECATED /* Use vout_window_ReportSize() in window provider instead. */<br>
+static inline void vout_display_SendEventDisplaySize(vout_display_t *vd,<br>
+ int width, int height)<br>
{<br>
- vout_display_SendEvent(vd, VOUT_DISPLAY_EVENT_DISPLAY_SIZE, width, height);<br>
+ vout_window_ReportSize(vd->cfg->window, width, height);<br>
}<br>
+<br>
static inline void vout_display_SendEventPicturesInvalid(vout_display_t *vd)<br>
{<br>
vout_display_SendEvent(vd, VOUT_DISPLAY_EVENT_PICTURES_INVALID);<br>
<br>
_______________________________________________<br>
vlc-commits mailing list<br>
vlc-commits@videolan.org<br>
https://mailman.videolan.org/listinfo/vlc-commits<br></blockquote>
</div>
</blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>