<!doctype html><html><head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body>If it does not depend on any library, I don't really see the point in having a module. If it does, then the point of my previous mail still stands.<br><br><div class="gmail_quote">Le 26 juin 2018 12:13:35 GMT+01:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div>
<div>On Tue, Jun 26, 2018, at 13:10, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>Hi,<br></div>
<div> <br></div>
<div> I would expect that the ML subcomponent handling preparsing is common core code, not per-plugin code though ... ?<br></div>
</blockquote><div><br></div>
<div>The ML will be a module. We'll be able to build VLC/LIBVLC without it.<br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div defang_data-gmailquote="yes"><div>Le 26 juin 2018 09:54:19 GMT+01:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre><div><br></div>
<div>On Tue, Jun 26, 2018, at 10:26, Rémi Denis-Courmont wrote:<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> Le lundi 25 juin 2018, 11:10:03 EEST Hugo Beauzée-Luyssen a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(173, 127, 168);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> ---<br></div>
<div> include/vlc_input.h | 14 ++++++++++++++<br></div>
<div> src/input/input_interface.h | 13 -------------<br></div>
<div> src/libvlccore.sym | 1 +<br></div>
<div> 3 files changed, 15 insertions(+), 13 deletions(-)<br></div>
</blockquote><div> <br></div>
<div> Exposing the preparser out of the core sounds like a bad idea. That makes it <br></div>
<div> hard, if at all possible, for multiple interfaces to use the same preparser.<br></div>
<div> <br></div>
<div> Plus that potentially means each interface has to reinvent the preparser <br></div>
<div> queuing and pacing, which is a big no no.<br></div>
</blockquote><div><br></div>
<div>I really think the medialibrary should use the input_thread_t directly and not use the preparser helper since the medialibrary already handle queuing and everything.<br></div>
<div><br></div>
<div>I don't see any problems about exposing this function.<br></div>
<div><br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> <br></div>
<div> -- <br></div>
<div> Rémi Denis-Courmont<br></div>
<div> <br></div>
<div> <br></div>
<div><hr><br></div>
<div> vlc-devel mailing list<br></div>
<div> To unsubscribe or modify your subscription options:<br></div>
<div> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><hr><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</pre></blockquote></div>
<div><br></div>
<div>--<br></div>
<div> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>