<html><head></head><body>Hi,<br>
<br>
I would expect that the ML subcomponent handling preparsing is common core code, not per-plugin code though ... ?<br><br><div class="gmail_quote">Le 26 juin 2018 09:54:19 GMT+01:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br>On Tue, Jun 26, 2018, at 10:26, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Le lundi 25 juin 2018, 11:10:03 EEST Hugo Beauzée-Luyssen a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> ---<br> include/vlc_input.h | 14 ++++++++++++++<br> src/input/input_interface.h | 13 -------------<br> src/libvlccore.sym | 1 +<br> 3 files changed, 15 insertions(+), 13 deletions(-)<br></blockquote> <br> Exposing the preparser out of the core sounds like a bad idea. That makes it <br> hard, if at all possible, for multiple interfaces to use the same preparser.<br> <br> Plus that potentially means each interface has to reinvent the preparser <br> queuing and pacing, which is a big no no.<br></blockquote><br>I really think the medialibrary should use the input_thread_t directly and not use the preparser helper since the medialibrary already handle queuing and everything.<br><br>I don't see any problems about exposing this function.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> <br> -- <br> Rémi Denis-Courmont<br> <br> <br><hr><br> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr><br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>