<html><head></head><body>Assertion in headers, or generally dependencies on config.h in headers<br><br><div class="gmail_quote">Le 2 juillet 2018 18:34:49 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2018-07-02 17:33, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> I have to disagree and your bugs are not an excuse for somebody else <br> to add bugs.<br><br> Fix your bugs.<br></blockquote><br>What are you talking about ?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br> Le 2 juillet 2018 18:30:31 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> <br> a écrit :<br><br> On 2018-07-02 17:25, Rémi Denis-Courmont wrote:<br><br> 1) This creates obvious overflow. Exactly the bug that the<br> inspiring kernel code is meant to fix... 2) So this won't work<br> for e.g. picture_t. <br><br><br> Then it won't.<br><br> 3, 4) Inspiring kernel code does address those issues. And<br> then, no assert in public headers. <br><br><br> We already have 3 of these (one from me, two from Thomas). In VLC core<br> headers it's fine as it's a controlled environment, even for external<br> code. For libvlc it wouldn't be OK at all.<br><br> Le 2 juillet 2018 18:18:27 GMT+03:00, "Hugo Beauzée-Luyssen"<br> <hugo@beauzee.fr> a écrit : On Mon, Jul 2, 2018, at 8:12 AM,<br> Rémi Denis-Courmont wrote: Same problems as before. -- Envoyé<br> de mon appareil Android avec Courriel K-9 Mail. Veuillez<br> excuser ma brièveté.<br><hr><br> vlc-devel mailing list To unsubscribe or modify your<br> subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a> - type sizes<br> (uint, uintptr...), The serie only affect code that was using<br> uint, except for patch 4 that was using uintptr, and I believe<br> uint to be a better fit; and patch 10. I'm fine with dropping<br> patch 10 for now. - order on decrement - acq_rel is not always<br> needed, I believe it is. - corner cases where the decrement is<br> known to not reach zero, Then don't use the helper in that<br> case? - corner cases where the decrement cannot be permitted<br> to reach zero(e.g. vlc_object_t, IIRC). Ditto. -- Envoyé de<br> mon appareil Android avec Courriel K-9 Mail. Veuillez excuser<br> ma brièveté.<br><hr><br> vlc-devel mailing list To unsubscribe or modify your<br> subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a> <br><br><br><hr><br><br> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br><br><br> -- <br> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez <br> excuser ma brièveté.<br><br><br><hr><br> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><br><hr><br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>