<html><head></head><body>I have to disagree and your bugs are not an excuse for somebody else to add bugs.<br>
<br>
Fix your bugs.<br><br><div class="gmail_quote">Le 2 juillet 2018 18:30:31 GMT+03:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 2018-07-02 17:25, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> 1) This creates obvious overflow. Exactly the bug that the inspiring <br> kernel code is meant to fix...<br><br> 2) So this won't work for e.g. picture_t.<br></blockquote><br>Then it won't.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br> 3, 4) Inspiring kernel code does address those issues.<br><br> And then, no assert in public headers.<br></blockquote><br>We already have 3 of these (one from me, two from Thomas). In VLC core <br>headers it's fine as it's a controlled environment, even for external <br>code. For libvlc it wouldn't be OK at all.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br> Le 2 juillet 2018 18:18:27 GMT+03:00, "Hugo Beauzée-Luyssen" <br> <hugo@beauzee.fr> a écrit :<br><br> On Mon, Jul 2, 2018, at 8:12 AM, Rémi Denis-Courmont wrote:<br><br> Same problems as before. -- Envoyé de mon appareil Android<br> avec Courriel K-9 Mail. Veuillez excuser ma brièveté.<br><hr><br> vlc-devel mailing list To unsubscribe or modify your<br> subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a> <br><br><br> - type sizes (uint, uintptr...), <br><br><br> The serie only affect code that was using uint, except for patch 4 that was using uintptr, and I believe uint to be a better fit; and patch 10. I'm fine with dropping patch 10 for now.<br><br> - order on decrement - acq_rel is not always needed, <br><br><br> I believe it is.<br><br> - corner cases where the decrement is known to not reach zero, <br><br><br> Then don't use the helper in that case?<br><br> - corner cases where the decrement cannot be permitted to<br> reach zero(e.g. vlc_object_t, IIRC). <br><br><br> Ditto.<br><br><br> -- <br> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez <br> excuser ma brièveté.<br><br><br><hr><br> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><br><hr><br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>