<html><head></head><body>I prefer thread fence over release order but I still don't know any way to make a helper without removing asserts, and I don't want to remove asserts.<br><br><div class="gmail_quote">Le 2 juillet 2018 18:46:58 GMT+03:00, Romain Vimont <rom1v@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Mon, Jul 02, 2018 at 06:32:33PM +0300, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Scratch picture_t, but still read-only objects (e.g. QString backend storage) or read-only accesses don't need release barrier.<br> <br> Also acquire barrier is not needed when reference count is more than 1-to-0.<br></blockquote><br>I'm glad you watched the video linked in the commit message more than 3<br>minutes (1), so that you were able to apply what the author explained in<br>some random file in VLC yesterday (2).<br><br>However, I think it would benefit the project more if this was done in<br>a helper used many times.<br><br>If you prefer to use the second version (with the explicit fence), we<br>can just change the implementation of vlc_atomic_rc_dec().<br><br>(1) <a href="https://www.youtube.com/watch?v=M15UKpNlpeM&feature=youtu.be&t=49m10s">https://www.youtube.com/watch?v=M15UKpNlpeM&feature=youtu.be&t=49m10s</a><br>(2) <a href="https://git.videolan.org/?p=vlc.git;a=commitdiff;h=ae2fed77b4833d522087176048d2586c60f9bd9b">https://git.videolan.org/?p=vlc.git;a=commitdiff;h=ae2fed77b4833d522087176048d2586c60f9bd9b</a><br><hr><br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>