<!doctype html><html><head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body>I vaguely recall arguing against abstraction breakage of GL some time ago. Maybe I recall wrong, or maybe it was about something else.<br><br><div class="gmail_quote">Le 4 juillet 2018 12:42:07 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>On Wed, Jul 4, 2018, at 11:25, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>I objected to the union as well, so that's not an argument that I'd receive.<br></div>
</blockquote><div><br></div>
<div>When did you object ? I don't see any replies when I proposed the patch to the mailing list<br></div>
<div><a href="https://mailman.videolan.org/pipermail/vlc-devel/2017-June/113751.html">https://mailman.videolan.org/pipermail/vlc-devel/2017-June/113751.html</a><br></div>
<div><br></div>
<blockquote type="cite"><div> <br></div>
<div> At least the current union breaks the abstraction unidirectionally. Not your patch, which breakd other GL provider users.<br></div>
<div><br></div>
<div defang_data-gmailquote="yes"><div>Le 4 juillet 2018 11:06:35 GMT+03:00, Pierre Lamot <pierre@videolabs.io> a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre><blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> I don't really see why this needs to be exposed here. Virtualized plugins <br></div>
<div> generally call the initialization and deinitialization callbacks in-situ.<br></div>
</blockquote><div><br></div>
<div>AFAIK, opengl modules don't have access to the picture size. <br></div>
<div><br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"> In fact, it looks like breaking the existing abstraction.<br></blockquote><div><br></div>
<div>Isn't this union purpose to break abstraction and handle special cases?<br></div>
<div><br></div>
<div>--<br></div>
<div>Pierre Lamot<br></div>
<div><br></div>
<div><br></div>
<div><br></div>
</pre></blockquote></div>
<div><br></div>
<div>--<br></div>
<div> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>