<html><head></head><body>Red herring. I never said that uint was enough for anything - except picture pool refs (which are bound to 65 IIRC). I even explicitly denied that already.<br><br><div class="gmail_quote">Le 4 juillet 2018 11:05:32 GMT+03:00, Romain Vimont <rom1v@videolabs.io> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Wed, Jul 04, 2018 at 09:24:19AM +0300, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Reason was provided multiple times.<br> <br> If you don't understand it, that's no excuse for bullshitting.<br></blockquote><br>OK, so let's review the reason you provided as comments of patch v2 once<br>again, so I get a chance to understand.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> 1) This creates obvious overflow.<br></blockquote><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> There was a protection and you removed it. By definition, we can<br> obviously not have more uintptr_max in-memory refs.<br></blockquote><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> In other words, there was a protection: the type was wide enough.<br></blockquote><br>Maybe I missed something, but how does this explain why the refcount<br>type for pictures has to be wider than the refcount type used for other<br>objects?<br><br>Are pictures refcounted more than what an "unsigned int" may provide?<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Le 3 juillet 2018 23:17:14 GMT+03:00, Romain Vimont <rom1v@videolabs.io> a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">No reason has been provided to keep a different type for pictures from<br>any other refcounts. It seems the difference was accidental, so the<br>types should now be made consistent.<br></blockquote></blockquote><hr><br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>