<html><head></head><body>I think it was already merged? Did you try rebasing?<br><br><div class="gmail_quote">Le 7 juillet 2018 13:10:44 GMT+03:00, Alejandro <alejandro.gonzalez.correo@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div dir="auto"><div>I'm sending this patch again because it didn't receive any answers in what I belive is a reasonable time. It should be simple to review. Please don't hesitate telling me if there's something wrong with the patch, as it would be my first contribution to this project and I could have done something wrong due to the lack of understanding and/or practice. Thank you for your time.<br><br><div class="gmail_quote"><div dir="ltr">---------- Forwarded message ---------<br>From: Alejandro González <a href="mailto:alejandro.gonzalez.correo@gmail.com" target="_blank" rel="noreferrer">alejandro.gonzalez.correo@gmail.com</a> <<a href="mailto:alejandro.gonzalez.correo@gmail.com" target="_blank" rel="noreferrer">alejandro.gonzalez.correo@gmail.com</a>><br>Date: jue., 21 de junio de 2018 19:53<br>Subject: [PATCH] Fix share/lua/README.txt HTTPd documentation<br>To: <<a href="mailto:vlc-devel@videolan.org" target="_blank" rel="noreferrer">vlc-devel@videolan.org</a>><br>Cc: Alejandro González <a href="mailto:alejandro.gonzalez.correo@gmail.com" target="_blank" rel="noreferrer">alejandro.gonzalez.correo@gmail.com</a> <<a href="mailto:alejandro.gonzalez.correo@gmail.com" target="_blank" rel="noreferrer">alejandro.gonzalez.correo@gmail.com</a>><br></div><br><br>According to my<br>
code review and testing, the vlc.httpd() Lua method does not take any<br>
arguments and neither support HTTPS in the current VLC version. Also, the<br>
documentation doesn't make it clear on what type of Lua modules it's<br>
available, when it can only be used in the context of interfaces.<br>
<br>
Some code snippets that seem to support the findings mentioned above:<br>
<a href="https://github.com/videolan/vlc/blob/master/modules/lua/intf.c#L258" rel="noreferrer noreferrer noreferrer" target="_blank">https://github.com/videolan/vlc/blob/master/modules/lua/intf.c#L258</a><br>
<a href="https://github.com/videolan/vlc/blob/master/modules/lua/libs/httpd.c#L82" rel="noreferrer noreferrer noreferrer" target="_blank">https://github.com/videolan/vlc/blob/master/modules/lua/libs/httpd.c#L82</a><br>
---<br>
share/lua/README.txt | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/share/lua/README.txt b/share/lua/README.txt<br>
index c5a7d68..6d6ee64 100644<br>
--- a/share/lua/README.txt<br>
+++ b/share/lua/README.txt<br>
@@ -99,11 +99,11 @@ Extension<br>
---------<br>
deactivate(): Deactivate current extension (after the end of the current function).<br>
<br>
-HTTPd<br>
------<br>
-http( host, port, [cert, key, ca, crl]): create a new HTTP (SSL) daemon.<br>
+HTTPd (only usable for interfaces)<br>
+----------------------------------<br>
+httpd(): create a new HTTP daemon.<br>
<br>
-local h = vlc.httpd( "localhost", 8080 )<br>
+local h = vlc.httpd()<br>
h:handler( url, user, password, callback, data ) -- add a handler for given url. If user and password are non nil, they will be used to authenticate connecting clients. callback will be called to handle connections. The callback function takes 7 arguments: data, url, request, type, in, addr, host. It returns the reply as a string.<br>
h:file( url, mime, user, password, callback, data ) -- add a file for given url with given mime type. If user and password are non nil, they will be used to authenticate connecting clients. callback will be called to handle connections. The callback function takes 2 arguments: data and request. It returns the reply as a string.<br>
h:redirect( url_dst, url_src ): Redirect all connections from url_src to url_dst.</div></div></div></blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>