<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">
code{white-space: pre-wrap;}
span.smallcaps{font-variant: small-caps;}
span.underline{text-decoration: underline;}
div.column{display: inline-block; vertical-align: top; width: 50%;}
</style>
</head>
<body>
<p>Hi Steve,</p>
<p>On 2018-07-11 08:52, Steve Lhomme wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> vlc | branch: master | Steve Lhomme <robux4@ycbcr.xyz> | Wed Jul 11 10:37:26 2018 +0200| [0e1886330f19fce5cdc47e6369ede560bdacaf72] | committer: Steve Lhomme
itml: fix the printf modifier for the pointer value</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<h3 id="httpgit.videolan.orggitweb.cgivlc.gitacommith0e1886330f19fce5cdc47e6369ede560bdacaf72">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0e1886330f19fce5cdc47e6369ede560bdacaf72</h3>
</blockquote>
<pre><code> modules/demux/playlist/itml.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/modules/demux/playlist/itml.c b/modules/demux/playlist/itml.c
index 449876f2d0..bb66765c19 100644
--- a/modules/demux/playlist/itml.c
+++ b/modules/demux/playlist/itml.c
@@ -282,8 +282,8 @@ static bool parse_tracks_dict( stream_t *p_demux, input_item_node_t *p_input_nod
parse_dict( p_demux, p_input_node, NULL, p_xml_reader,
"dict", tracks_elements );
- msg_Info( p_demux, "added %zi tracks successfully",
- (size_t)p_demux->p_sys );
+ msg_Info( p_demux, "added %" PRIiPTR " tracks successfully",
+ p_demux->p_sys );</code></pre>
</blockquote>
<p>Even though the previous implementation was not correct (as the bit-representation in <code>p_demux->p_sys</code> is a <code>uintptr_t</code> and not <code>size_t</code>), this change is still in the wrong - and I must assume that you got a warning from compiling the above.</p>
<p>A cast to <code>uintptr_t</code> is necessary, and the format-specifier should be using <code>PRIuPTR</code>. Though, it is certainly debatable whether <code>uintptr_t</code> should be used in the code at all.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> return true;
}
_______________________________________________
vlc-commits mailing list
vlc-commits@videolan.org
https://mailman.videolan.org/listinfo/vlc-commits</code></pre>
</blockquote>
</body>
</html>