<div dir="ltr"><div>Hi,</div><div><br></div><div>What change are you suggesting which could improve the patch?<br></div><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 15, 2018 at 7:13 PM Marvin Scholz <<a href="mailto:epirat07@gmail.com">epirat07@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, thanks for your patch.<br>
<br>
I am not sure though if doing this in a specific interface only<br>
(in this case the qt interface) is a good solution.<br>
<br>
On 15 Jul 2018, at 15:40, Vaishnav Sivadas wrote:<br>
<br>
> Autoplays a video upon entering full screen which enhances UX<br>
><br>
> fixes #8533<br>
> ---<br>
>  modules/gui/qt/input_manager.cpp | 6 ++++++<br>
>  1 file changed, 6 insertions(+)<br>
><br>
> diff --git a/modules/gui/qt/input_manager.cpp <br>
> b/modules/gui/qt/input_manager.cpp<br>
> index 4c28933395..c94cffe164 100644<br>
> --- a/modules/gui/qt/input_manager.cpp<br>
> +++ b/modules/gui/qt/input_manager.cpp<br>
> @@ -1287,5 +1287,11 @@ int MainInputManager::PLItemRemoved( <br>
> vlc_object_t *obj, const char *,<br>
>  void MainInputManager::changeFullscreen( bool new_val )<br>
>  {<br>
>      if ( var_GetBool( THEPL, "fullscreen" ) != new_val)<br>
> +    {<br>
>          var_SetBool( THEPL, "fullscreen", new_val );<br>
> +    }<br>
> +    if (new_val)<br>
> +    {<br>
> +        playlist_Play( THEPL );<br>
> +    }<br>
>  }<br>
> -- <br>
> 2.17.1<br>
><br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>Vaishanav Sivadas<br></div><div>Amrita University.<br></div><div><a href="https://vaishnavsivadas.wordpress.com/" target="_blank">Wordpress</a> | <a href="https://github.com/vaishnavsivadas" target="_blank">Github</a> <br></div></div></div></div></div>