<div dir="ltr"><div>Hi,<br></div><div><br></div><div>Where should I make the changes? Should I add the feature to each platforms separately or is there a single place where I could make the change? </div></div><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 15, 2018 at 10:14 PM David Fuhrmann <<a href="mailto:david.fuhrmann@gmail.com">david.fuhrmann@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Hi,<div><br></div><div>I would advise you to first implement the feature in core and add the option itself.</div><div>Adding to to the simple preferences can be done afterwards, if we feel its important enough. I would probably add it to the video section.</div><div><br></div><div>BR. David<br><div><br><blockquote type="cite"><div>Am 15.07.2018 um 18:31 schrieb Vaishnav Sivadas <<a href="mailto:vaishnavsivadas@gmail.com" target="_blank">vaishnavsivadas@gmail.com</a>>:</div><br class="m_-3033111977755186273Apple-interchange-newline"><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div>Hi again,<span class="m_-3033111977755186273Apple-converted-space"> </span><br></div><div>Sorry, a correction there. I guess it would be perfect if it comes inside Video section in Tools->Preferences->Video. Any suggestions guys? Shall I proceed with it?<br></div></div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br></div><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr">On Sun, Jul 15, 2018 at 9:39 PM Vaishnav Sivadas <<a href="mailto:vaishnavsivadas@gmail.com" target="_blank">vaishnavsivadas@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi,</div><div>Will it be okay, if I add a toggle option in the look and feel section which comes in Preferences->Interface? If not, what can be done to make the feature more convenient?<br></div><div><div><div><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 15, 2018 at 7:32 PM Alexandre Janniaux <<a href="mailto:alexandre.janniaux@gmail.com" target="_blank">alexandre.janniaux@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi,</div><div><br></div><div>Thank you for taking the time to make this patch! However, it doesn't seem to be what the ticket is saying. It will force this new behaviour for Qt whereas the ticket's suggestion is to add a new parameter to enable this feature.</div><div><br></div><div>There is also the behaviour consistency issue when using another interface as mentionned by Marvin.</div><div><br></div><div>I don't know if this feature is really wanted by many people, but maybe you could add this new parameter and update the other interfaces. I believe it would be difficult to find a common location for it as this feature might not really be wanted for libvlc and is only related to interfaces themselves.</div><br></div><div class="gmail_extra"><br><div class="gmail_quote">2018-07-15 15:48 GMT+02:00 Vaishnav Sivadas<span class="m_-3033111977755186273Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:vaishnavsivadas@gmail.com" target="_blank">vaishnavsivadas@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi,</div><div><br></div><div>What change are you suggesting which could improve the patch?<br></div><div><div class="m_-3033111977755186273m_8178152492448505778m_-7940737811056481998m_-303802876538975579h5"><br><div class="gmail_quote"><div dir="ltr">On Sun, Jul 15, 2018 at 7:13 PM Marvin Scholz <<a href="mailto:epirat07@gmail.com" target="_blank">epirat07@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Hi, thanks for your patch.<br><br>I am not sure though if doing this in a specific interface only<br>(in this case the qt interface) is a good solution.<br><br>On 15 Jul 2018, at 15:40, Vaishnav Sivadas wrote:<br><br>> Autoplays a video upon entering full screen which enhances UX<br>><br>> fixes #8533<br>> ---<br>> modules/gui/qt/input_manager.cpp | 6 ++++++<br>> 1 file changed, 6 insertions(+)<br>><br>> diff --git a/modules/gui/qt/input_manager.cpp<span class="m_-3033111977755186273Apple-converted-space"> </span><br>> b/modules/gui/qt/input_manager.cpp<br>> index 4c28933395..c94cffe164 100644<br>> --- a/modules/gui/qt/input_manager.cpp<br>> +++ b/modules/gui/qt/input_manager.cpp<br>> @@ -1287,5 +1287,11 @@ int MainInputManager::PLItemRemoved(<span class="m_-3033111977755186273Apple-converted-space"> </span><br>> vlc_object_t *obj, const char *,<br>> void MainInputManager::changeFullscreen( bool new_val )<br>> {<br>> if ( var_GetBool( THEPL, "fullscreen" ) != new_val)<br>> + {<br>> var_SetBool( THEPL, "fullscreen", new_val );<br>> + }<br>> + if (new_val)<br>> + {<br>> + playlist_Play( THEPL );<br>> + }<br>> }<br>> --<span class="m_-3033111977755186273Apple-converted-space"> </span><br>> 2.17.1<br>><br>> _______________________________________________<br>> vlc-devel mailing list<br>> To unsubscribe or modify your subscription options:<br>><span class="m_-3033111977755186273Apple-converted-space"> </span><a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>_______________________________________________<br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div><br clear="all"><br></div></div><span class="m_-3033111977755186273m_8178152492448505778m_-7940737811056481998m_-303802876538975579HOEnZb"><font color="#888888">--<span class="m_-3033111977755186273Apple-converted-space"> </span><br><div dir="ltr" class="m_-3033111977755186273m_8178152492448505778m_-7940737811056481998m_-303802876538975579m_-8855671172158021463gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>Vaishanav Sivadas<br></div><div>Amrita University.<br></div><div><a href="https://vaishnavsivadas.wordpress.com/" target="_blank">Wordpress</a><span class="m_-3033111977755186273Apple-converted-space"> </span>|<span class="m_-3033111977755186273Apple-converted-space"> </span><a href="https://github.com/vaishnavsivadas" target="_blank">Github</a><span class="m_-3033111977755186273Apple-converted-space"> </span><br></div></div></div></div></font></span></div><br>_______________________________________________<br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote></div><br></div>_______________________________________________<br>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div><br clear="all"><br>--<span class="m_-3033111977755186273Apple-converted-space"> </span><br><div dir="ltr" class="m_-3033111977755186273m_8178152492448505778m_-7940737811056481998gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>Vaishanav Sivadas<br></div><div>Amrita University.<br></div><div><a href="https://vaishnavsivadas.wordpress.com/" target="_blank">Wordpress</a><span class="m_-3033111977755186273Apple-converted-space"> </span>|<span class="m_-3033111977755186273Apple-converted-space"> </span><a href="https://github.com/vaishnavsivadas" target="_blank">Github</a><span class="m_-3033111977755186273Apple-converted-space"> </span><br></div></div></div></div></div></div></div></div></blockquote></div><br clear="all" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important">--<span class="m_-3033111977755186273Apple-converted-space"> </span></span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr" class="m_-3033111977755186273m_8178152492448505778gmail_signature" data-smartmail="gmail_signature" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div dir="ltr"><div><div>Vaishanav Sivadas<br></div><div>Amrita University.<br></div><div><a href="https://vaishnavsivadas.wordpress.com/" target="_blank">Wordpress</a><span class="m_-3033111977755186273Apple-converted-space"> </span>|<span class="m_-3033111977755186273Apple-converted-space"> </span><a href="https://github.com/vaishnavsivadas" target="_blank">Github</a><span class="m_-3033111977755186273Apple-converted-space"> </span><br></div></div></div></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important">vlc-devel mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important">To unsubscribe or modify your subscription options:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><a href="https://mailman.videolan.org/listinfo/vlc-devel" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></div></blockquote></div><br></div></div>_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div>Vaishanav Sivadas<br></div><div>Amrita University.<br></div><div><a href="https://vaishnavsivadas.wordpress.com/" target="_blank">Wordpress</a> | <a href="https://github.com/vaishnavsivadas" target="_blank">Github</a> <br></div></div></div></div>