<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">
code{white-space: pre-wrap;}
span.smallcaps{font-variant: small-caps;}
span.underline{text-decoration: underline;}
div.column{display: inline-block; vertical-align: top; width: 50%;}
</style>
</head>
<body>
<p>Hi,</p>
<p>Thanks for reviewing.</p>
<p>On 2018-07-16 11:57, Steve Lhomme wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Although I said everything in libmatroska can be used, this class is not really supposed
to be used, hence the name Internal.</code></pre>
</blockquote>
<p>In the future, do not use <code>public</code> inheritance in <em>libmatroska</em> for said entities as that would have prevented people from using it the way it is now.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> But in reality it should be but with a different name. So we can use it and will change
the name when/if it does.</code></pre>
</blockquote>
<p>You don’t need to rename it, one could argue that <em>“Internal”</em> means the internal material of each block, where <code>KaxBlock</code> and <code>KaxSimpleBlock</code> are wrappers around said internal material.</p>
<p>It might also be somewhat problematic renaming it now, unless you want to break a lot of projects. I searched <em>github</em> for people using <code>KaxInternalBlock</code>, and I am definitely not the first, and probably not the last.</p>
</body>
</html>