<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">
code{white-space: pre-wrap;}
span.smallcaps{font-variant: small-caps;}
span.underline{text-decoration: underline;}
div.column{display: inline-block; vertical-align: top; width: 50%;}
</style>
</head>
<body>
<p>Hi Steve,</p>
<p>On 2018-07-20 13:54, Steve Lhomme wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> I disagree. VLC_Exxx and VLC_SUCCESS are for functions and even VLC_API functions that
return an int.</code></pre>
</blockquote>
<p>It was a note related to the entire patch, that happened to appear at a function where <code>-1</code> does not denote error. I understand that you might interpret what I wrote as if I am saying that <code>vlc_array_find</code> should use <em>error-codes</em>, but honestly I thought you’d know be better than that. <code>;-)</code></p>
<p>Though, it was not entire clear from what I was writing so for that I apologize.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Here we return an invalid array index which may have its own define but is not an error
code. But maybe I misread because the -1 is not even from this commit.</code></pre>
</blockquote>
<p>It was unfortunate that I wrote it under the function that is supposed to find the index of an item; I do agree that <code>vlc_array_find</code> not finding an element is not an error, and for what it is worth me and Romain spoke about this on <em>IRC</em>.</p>
<p>Best Regards,<br />
Filip</p>
</body>
</html>