<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">
code{white-space: pre-wrap;}
span.smallcaps{font-variant: small-caps;}
span.underline{text-decoration: underline;}
div.column{display: inline-block; vertical-align: top; width: 50%;}
</style>
</head>
<body>
<p>Hi Rémi,</p>
<p>On 2018-07-21 08:25, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le vendredi 20 juillet 2018, 12:55:19 EEST Filip Roséen a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Hi again,
As the patch in which this email is a reply to includes an
*ABI*-breaking change, it cannot be backported to `3.0.0` *as-is*.
I am not sure how many users rely on `--recursive=none`, though it's
probably not many as it has been broken for quite some time, and I
could not find a single ticket or post that asks about the breakage.
With that in mind we have a few options:
1. remove support for `--recursive=none`, conditionally supporting
it in *trunk* (though if removed in one, it is probably best to
do it in both).
2. write a somewhat ugly backportable fix</code></pre>
</blockquote>
<pre><code> I suspect that --recursive can be removed altogether. We need a depth limit to
prevent infinite recursion, and that effectively covers both none (depth=0 or
1 maybe) and expand modes.</code></pre>
</blockquote>
<p>Should we then deprecate <code>--recursive</code> first, introduce <code>--depth</code> and remove <code>--recursive</code> in the next release (ie. current <em>trunk</em>)? I believe we do need a fix for <code>3.0.0</code>, and I am not sure what the policy is on option removal between majors; do we have such policy?</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> And the distinction between recursive and collapse mode is kind of hysterical
raisins.</code></pre>
</blockquote>
<p>Indeed, and given the names for the different options.. things got way worse. Who would on their first guess actually be able to get what the difference is between <code>--recursive=collapse</code> and <code>--recursive=expand</code>, and who would think <code>--recursive=none</code> actually meant something like an imaginary <code>--filter-out-directories</code>.</p>
<p>Best Regards,<br />
Filip</p>
</body>
</html>