<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div><br></div>
<div><br></div>
<div><br></div>
<div>On Sat, Jul 21, 2018, at 07:25, Filip Roséen wrote:<br></div>
<blockquote type="cite"><p>Hi Rémi,<br></p><p>On 2018-07-21 08:22, Rémi Denis-Courmont wrote:<br></p><blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;color:rgb(80, 0, 80);"><pre><code style="white-space: pre-wrap;"> That seems very unnatural to me, and is only likely to either perpetuate the
problem (because people forget the flag), or trigger cargo-cult (because
people copy the flag not figuring out why).
IMO, there are no valid reasons why recursion depth should be ignored. This
was a bug.</code><br></pre></blockquote><p>I definitely agree with you on the above, though I am afraid that this bug has now slipped out in the open and people being people, I would not be surprised if people actually depend on this behavior now.<br></p><p>It is possible to fix the issue by not changing the behavior of <code style="white-space: pre-wrap;">libvlc_MetadataRequest</code> at all, though it involves accessing the <i>preparser</i> from the <i>libvlc object</i>, which to me is not ideal.<br></p><p>What do you think we can do about this? Input is much appreciated as I really want this whole mess cleaned up.<br></p></blockquote><div><br></div>
<div>This function is only used by libvlc_media and the playlist engine.<br></div>
<div>When it's called from libvlc (then explicitly requested by an user), the preparse_depth should be forced to 1, otherwise the preparsing could be skipped. When this function is called from the playlist, the preparse_depth should not be touched.<br></div>
<div><br></div>
<div>Btw, I don't like this function at all (the name is very bad). We could remove it and implement what we want in libvlc and playlist.<br></div>
<div><br></div>
<div><br></div>
<div><br></div>
<blockquote type="cite"><p><br></p><div>Best Regards,<br></div>
<div> Filip<br></div>
<p><br></p><div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</body>
</html>