<!doctype html><html><head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body>You have an overflow bug there.<br><br><div class="gmail_quote">Le 17 août 2018 15:21:15 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>On Fri, Aug 17, 2018, at 14:15, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>How do you make the ID temporally unique?<br></div>
</blockquote><div><br></div>
<div>cf. es_out.c:<br></div>
<div>es->i_meta_id = p_sys->i_id++; /* always incremented */<br></div>
<div><br></div>
<blockquote type="cite"><div> <br></div>
<div> And if it's not fixed in 4.0 break, when will it be? You want to break compatibility after 4.0?<br></div>
</blockquote><div><br></div>
<div>I don't understand, this need to be fixed for 4.0 with the new input manager.<br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div defang_data-gmailquote="yes"><div>Le 17 août 2018 14:52:21 GMT+03:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre><div>I would prefer to keep using the integer i_id as a unique es track identifier since it's very simple to handle.<br></div>
<div><br></div>
<div>The main input or slaves goes through the same es_out instance that keep the list of all ES tracks, so this should be a simple issue to fix. <br></div>
<div><br></div>
<div>So, either we don't expose fmt.i_id from the demux and always increment an unique id (like it's already done if fmt.i_id < 0). But then, this break es track selection (when passing parameters per es).<br></div>
<div><br></div>
<div>Of we mix both solution: if the demux fmt.i_id is not automatic (not -1), we iterate through our es tracks to make sure it is unique. If it's not unique: ERROR, or use the incremented unique value.<br></div>
<div> <br></div>
<div>On Fri, Aug 17, 2018, at 13:38, Francois Cartegnie wrote:<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> Le 17/08/2018 à 13:22, Rémi Denis-Courmont a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(173, 127, 168);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div> FMT ID is useful metadata in some cases. But ES ID should not even exist, as we cannot guarantee uniqueness in case of slave demuxers.<br></div>
<div> <br></div>
</blockquote><div> <br></div>
<div> Then every user would need to know or guess stream creation order to<br></div>
<div> pass parameters per es.<br></div>
<div> <br></div>
<div> Unfair dice or crystal ball also required to remap es in muxers.<br></div>
<div> <br></div>
<div> -- <br></div>
<div> Francois Cartegnie<br></div>
<div> VideoLAN - VLC Developer<br></div>
<div><hr><br></div>
<div> vlc-devel mailing list<br></div>
<div> To unsubscribe or modify your subscription options:<br></div>
<div> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><hr><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</pre></blockquote></div>
<div><br></div>
<div>--<br></div>
<div> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div><br>
-- <br>
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>