<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div><br></div>
<div>On Wed, Sep 5, 2018, at 06:34, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>It is probably not a good idea for UI to wait on seek anyhow, because it could take arbitrarily long (stuck network).<br></div>
</blockquote><div><br></div>
<div>I know. I don't want the UI to block waiting for anything, but be notified when some events are processed.<br></div>
<div><br></div>
<div>What I'm an trying to fix is the seekbar value that is inconsistent when you seek.<br></div>
<div><br></div>
<div>I explain with the worst case scenario (that happens very often):<br></div>
<div> - The player time is 60s<br></div>
<div> - The UI ask the player to seek to 120s, and set the seekbar progress to 120s<br></div>
<div> - In the meantime, the input_thread finish a demux() call and update the time values: 61ms. The UI update the progress value to 61.<br></div>
<div> - The seek command is processed, the input_thread signal the new time: around 120s, the UI update the progress value to 120s.<br></div>
<div><br></div>
<div>This result to a glitch on the seekbar: 60 -> 120 -> 61 -> 120<br></div>
<div> <br></div>
<blockquote type="cite"><div> We should rather expose an event when the correlation between monotonic clock and play time changes - regardless of why: seek, pause, rate change, buffer refill...<br></div>
</blockquote><div><br></div>
<div>Maybe. This current solution is not correct as I explained in my first comment.<br></div>
<div><br></div>
<div>My other solution was to notify when a seek started (with the time/pos value requested) and notify when this seek ended (and failed). But this looks like your solution, that is more generic.<br></div>
<div><br></div>
<div>One problem with your solution: I would like to notify the next probable time/pos value (when you start a seek). That's way the UI can either change the value of the seekbar (of display an indefinite progress).<br></div>
<div><br></div>
<blockquote type="cite"><div> <br></div>
<div> Then the UI can update the slider and (re)program its update timer if it wants.<br></div>
<div> -- <br></div>
<div> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</body>
</html>