<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">
code{white-space: pre-wrap;}
span.smallcaps{font-variant: small-caps;}
span.underline{text-decoration: underline;}
div.column{display: inline-block; vertical-align: top; width: 50%;}
</style>
</head>
<body>
<p>Hi Remi,</p>
<p>On 2018-09-28 15:23, Rémi Denis-Courmont wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Le vendredi 28 septembre 2018, 15:04:33 EEST Filip Roséen a écrit :</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> LGTM, as long as we are sure that we will not (once again) step into
life-time issues related to the ownership of
`video_format_t.p_palette` (but as it worked before, well.. it at
least wouldn't get worse than what we had previously).</code></pre>
</blockquote>
<pre><code> I have said it before and I will say it again: we should just kill p_palette
so that video format is actually POD like so much code assumes. The troubles
are not worth the benefits. It is just daft to treat paletized formats as
decoded formats nowadays.</code></pre>
</blockquote>
<p>Mhm, I definitely agree!</p>
<p>I have never been a fan of <code>p_palette</code>, and given the amount of trouble we have had with lifetime problems due to changes not taking the ownership into account. I would happily see it being <em>plain-old-data</em>, and it would save us so much time when we have some obscure patch because of some developer mismatching <em>copy-by-value</em> vs <code>video_format_Clean</code>/<code>video_format_Init</code>/etc.</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> We should just have a common helper to dereference paletized pictures into YUV
or RGB in the few affected video decoders.</code></pre>
</blockquote>
<p>/F</p>
</body>
</html>