<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta http-equiv="Content-Style-Type" content="text/css" />
<meta name="generator" content="pandoc" />
<title></title>
<style type="text/css">
code{white-space: pre-wrap;}
span.smallcaps{font-variant: small-caps;}
span.underline{text-decoration: underline;}
div.column{display: inline-block; vertical-align: top; width: 50%;}
</style>
</head>
<body>
<p>Hi Zhao,</p>
<p>On 2018-09-30 01:21, Zhao Zhili wrote:</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> Ping for review.</code></pre>
</blockquote>
<p>Given that I was the one that suggested these changes to be made, it might not be too surprising that I would give you a <em>LGTM</em> in terms of change in behavior. I am however a little sad to see one comment being lost as part of moving the block of code, with that said: the code-block is easy enough to understand even without said comment - so in my book it is not the end of the world.</p>
<p>/F</p>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> 于 2018年9月24日 GMT+08:00 下午5:43:25, Zhao Zhili <quinkblack@foxmail.com> 写到:</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On Sep 24, 2018, at 5:10 PM, Thomas Guillem <thomas@gllm.fr> wrote:
Why ?</code></pre>
</blockquote>
<pre><code>p_sys->i_length =
p_sys->subtitles.p_array[p_sys->subtitles.i_count-1].i_stop;
The i_length field is set according to the PTS of the last frame. The
last frame may not have the largest PTS before reorder.
cf.
https://mailman.videolan.org/pipermail/vlc-devel/2018-September/121233.html</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> On Thu, Sep 20, 2018, at 17:36, Zhao Zhili wrote:</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> ---
modules/demux/subtitle.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/modules/demux/subtitle.c b/modules/demux/subtitle.c
index 3b9836587a..4b7eeefd59 100644
--- a/modules/demux/subtitle.c
+++ b/modules/demux/subtitle.c
@@ -676,12 +676,6 @@ static int Open ( vlc_object_t *p_this )
msg_Dbg(p_demux, "loaded %zu subtitles",</code></pre>
<p>p_sys->subtitles.i_count );</p>
<pre><code> - /* Fix subtitle (order and time) *** */
- p_sys->subtitles.i_current = 0;
- p_sys->i_length = 0;
- if( p_sys->subtitles.i_count > 0 )
- p_sys->i_length = p_sys->subtitles.p_array[p_sys-</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<h3 id="subtitles.i_count-1.i_stop">subtitles.i_count-1].i_stop;</h3>
<p>/* *** add subtitle ES *** <em>/ if( p_sys->props.i_type == SUB_TYPE_SSA1 || p_sys->props.i_type == SUB_TYPE_SSA2_4 || @@ -698,6 +692,11 @@ static int Open ( vlc_object_t </em>p_this ) else es_format_Init( &fmt, SPU_ES, VLC_CODEC_SUBT );</p>
</blockquote>
<pre><code> + p_sys->subtitles.i_current = 0;
+ p_sys->i_length = 0;
+ if( p_sys->subtitles.i_count > 0 )
+ p_sys->i_length = p_sys->subtitles.p_array[p_sys-</code></pre>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> subtitles.i_count-1].i_stop;</code></pre>
<ul>
<li>/* Stupid language detection in the filename <em>/ char </em> psz_language = get_language_from_filename( p_demux- psz_filepath );</li>
</ul>
</blockquote>
<pre><code> --
2.19.0.rc1
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel</code></pre>
<hr style="height:1px;margin-bottom:20px;background-color:#ddd;color:#ddd" />
<p>vlc-devel mailing list To unsubscribe or modify your subscription options: https://mailman.videolan.org/listinfo/vlc-devel</p>
</blockquote>
</blockquote>
</blockquote>
<pre><code> --
使用 K-9 Mail 发送自我的Android设备。</code></pre>
</blockquote>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;color:#500050">
<pre><code> _______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel</code></pre>
</blockquote>
</body>
</html>