<html><head></head><body>Ping for review.<br><br><div class="gmail_quote">于 2018年9月24日 GMT+08:00 下午5:43:25, Zhao Zhili <quinkblack@foxmail.com> 写到:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">On Sep 24, 2018, at 5:10 PM, Thomas Guillem <thomas@gllm.fr> wrote:<br><br>Why ?<br></blockquote><br>p_sys->i_length = p_sys->subtitles.p_array[p_sys->subtitles.i_count-1].i_stop;<br><br>The i_length field is set according to the PTS of the last frame. The last frame may not have the largest PTS before reorder.<br><br>cf. <a href="https://mailman.videolan.org/pipermail/vlc-devel/2018-September/121233.html">https://mailman.videolan.org/pipermail/vlc-devel/2018-September/121233.html</a><br><br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><br>On Thu, Sep 20, 2018, at 17:36, Zhao Zhili wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><hr>modules/demux/subtitle.c | 11 +++++------<br>1 file changed, 5 insertions(+), 6 deletions(-)<br><br>diff --git a/modules/demux/subtitle.c b/modules/demux/subtitle.c<br>index 3b9836587a..4b7eeefd59 100644<br>--- a/modules/demux/subtitle.c<br>+++ b/modules/demux/subtitle.c<br>@@ -676,12 +676,6 @@ static int Open ( vlc_object_t *p_this )<br><br>    msg_Dbg(p_demux, "loaded %zu subtitles", p_sys->subtitles.i_count );<br><br>-    /* Fix subtitle (order and time) *** */<br>-    p_sys->subtitles.i_current = 0;<br>-    p_sys->i_length = 0;<br>-    if( p_sys->subtitles.i_count > 0 )<br>-        p_sys->i_length = p_sys->subtitles.p_array[p_sys-<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">subtitles.i_count-1].i_stop;<br></blockquote>-<br>    /* *** add subtitle ES *** */<br>    if( p_sys->props.i_type == SUB_TYPE_SSA1 ||<br>             p_sys->props.i_type == SUB_TYPE_SSA2_4 ||<br>@@ -698,6 +692,11 @@ static int Open ( vlc_object_t *p_this )<br>    else<br>        es_format_Init( &fmt, SPU_ES, VLC_CODEC_SUBT );<br><br>+    p_sys->subtitles.i_current = 0;<br>+    p_sys->i_length = 0;<br>+    if( p_sys->subtitles.i_count > 0 )<br>+        p_sys->i_length = p_sys->subtitles.p_array[p_sys-<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">subtitles.i_count-1].i_stop;<br></blockquote>+<br>    /* Stupid language detection in the filename */<br>    char * psz_language = get_language_from_filename( p_demux-<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">psz_filepath );<br></blockquote><br>-- <br>2.19.0.rc1<hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><br></pre></blockquote></div><br>-- <br>使用 K-9 Mail 发送自我的Android设备。</body></html>