<html><head></head><body><div class="ydpa85d53f1yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><span>Am Sonntag, 28. Oktober 2018, 15:35:31 MEZ hat Rémi Denis-Courmont <git@videolan.org> Folgendes geschrieben:<br><br>> vlc | branch: master | Rémi Denis-Courmont <remi@remlab.net> | Sun Oct 28 16:31:45 2018 +0200| [707c2f42bdc92567a3baa1ca1df3090bcc4ae218] | committer: Rémi Denis-Courmont<br>> <br>> goom: remove useless filter_sys_t<br>> <br>> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=707c2f42bdc92567a3baa1ca1df3090bcc4ae218<br>> ---<br>> <br>> modules/visualization/goom.c | 54 ++++++++++++++++----------------------------<br>> 1 file changed, 20 insertions(+), 34 deletions(-)<br>> <br>> diff --git a/modules/visualization/goom.c b/modules/visualization/goom.c<br>> index 039971be08..07191760bd 100644<br>> --- a/modules/visualization/goom.c<br>> +++ b/modules/visualization/goom.c<br>> @@ -116,15 +110,11 @@ static void *Thread( void * );<br>> static int Open( vlc_object_t *p_this )<br>> {<br>> filter_t *p_filter = (filter_t *)p_this;<br>> - filter_sys_t *p_sys;<br>> goom_thread_t *p_thread;<br>> video_format_t fmt;<br>> <br>> - /* Allocate structure */<br>> - p_sys = p_filter->p_sys = malloc( sizeof( filter_sys_t ) );<br>> -<br>> /* Create goom thread */<br>> - p_sys->p_thread = p_thread = calloc( 1, sizeof(*p_thread) );<br>> + p_thread = calloc( 1, sizeof(*p_thread) );<br>> <br>> const int width = p_thread->i_width = var_InheritInteger( p_filter, "goom-width" );<br>> const int height = p_thread->i_height = var_InheritInteger( p_filter, "goom-height" );<br><br>Shouldn't this be:<br>+ p_filter->p_sys = p_thread = calloc( 1, sizeof(*p_thread) );<br><br></span><div><br></div></div></body></html>