<!doctype html><html><head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body>I cannot elaborate on the fact that the code makes no sense to me since it makes no sense to me.<br><br><div class="gmail_quote">Le 30 novembre 2018 10:33:22 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div>
<div>On Thu, Nov 29, 2018, at 14:08, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>I don't follow the causal link here. This code does not make sense to me.<br></div>
</blockquote><div><br></div>
<div>Could you elaborate please ? I don't get the problem.<br></div>
<div>This patch is straight forward, it just forward the cork setting to the player.<br></div>
<div><br></div>
<blockquote type="cite"><div><br></div>
<div defang_data-gmailquote="yes"><div>Le 28 novembre 2018 16:08:15 GMT+02:00, Victorien Le Couviour--Tuffet <victorien.lecouviour.tuffet@gmail.com> a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre><div>Since the player now handles the playlist cork option, we need to<br></div>
<div>configure it from this variable at the beginning.<hr> src/libvlc.c | 2 ++<br></div>
<div> 1 file changed, 2 insertions(+)<br></div>
<div><br></div>
<div>diff --git a/src/libvlc.c b/src/libvlc.c<br></div>
<div>index 2f8ded692e..f5d6382cfd 100644<br></div>
<div>--- a/src/libvlc.c<br></div>
<div>+++ b/src/libvlc.c<br></div>
<div>@@ -135,6 +135,7 @@ PlaylistConfigureFromVariables(vlc_playlist_t *playlist, vlc_object_t *obj)<br></div>
<div> media_stopped_action = VLC_PLAYER_MEDIA_STOPPED_CONTINUE;<br></div>
<div> <br></div>
<div> bool start_paused = var_InheritBool(obj, "start-paused");<br></div>
<div>+ bool playlist_cork = var_InheritBool(obj, "playlist-cork");<br></div>
<div> <br></div>
<div> vlc_playlist_Lock(playlist);<br></div>
<div> vlc_playlist_SetPlaybackOrder(playlist, order);<br></div>
<div>@@ -146,6 +147,7 @@ PlaylistConfigureFromVariables(vlc_playlist_t *playlist, vlc_object_t *obj)<br></div>
<div> * implementation detail */<br></div>
<div> vlc_player_SetMediaStoppedAction(player, media_stopped_action);<br></div>
<div> vlc_player_SetStartPaused(player, start_paused);<br></div>
<div>+ vlc_player_SetPauseOnCork(player, playlist_cork);<br></div>
<div> <br></div>
<div> vlc_playlist_Unlock(playlist);<br></div>
<div> }<br></div>
</pre></blockquote></div>
<div><br></div>
<div>-- <br></div>
<div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>