<!DOCTYPE html>
<html>
<head>
<title></title>
<style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style>
</head>
<body><div><br></div>
<div>On Thu, Nov 29, 2018, at 14:49, Rémi Denis-Courmont wrote:<br></div>
<blockquote type="cite"><div>I doubt that users expect the splitter setup to apply to all vouts at the same time always, frankly.<br></div>
</blockquote><div><br></div>
<div>That's good point. Specially it you call this function several time, you'll end up setting splitter on already splitted vout.<br></div>
<div><br></div>
<blockquote type="cite"><div defang_data-gmailquote="yes"><div>Le 28 novembre 2018 16:50:26 GMT+02:00, Victorien Le Couviour--Tuffet <victorien.lecouviour.tuffet@gmail.com> a écrit :<br></div>
<blockquote defang_data-gmailquote="yes" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><pre><div>The vout can't handle live "video-splitter" change for now.<br></div>
<div>To work-around this issue, this function will set this variable and<br></div>
<div>restart all vouts.<hr> include/vlc_player.h | 10 +++++++++-<br></div>
<div> src/input/player.c   | 11 +++++++++--<br></div>
<div> src/libvlccore.sym   |  1 +<br></div>
<div> 3 files changed, 19 insertions(+), 3 deletions(-)<br></div>
<div><br></div>
<div>diff --git a/include/vlc_player.h b/include/vlc_player.h<br></div>
<div>index 78d78d29d3..4c0d1abe74 100644<br></div>
<div>--- a/include/vlc_player.h<br></div>
<div>+++ b/include/vlc_player.h<br></div>
<div>@@ -332,7 +332,6 @@ enum vlc_player_subtitle_sync<br></div>
<div>  */<br></div>
<div> enum vlc_vout_filter_type<br></div>
<div> {<br></div>
<div>-    VLC_VOUT_FILTER_VIDEO_SPLITTER,<br></div>
<div>     VLC_VOUT_FILTER_VIDEO_FILTER,<br></div>
<div>     VLC_VOUT_FILTER_SUB_SOURCE,<br></div>
<div>     VLC_VOUT_FILTER_SUB_FILTER,<br></div>
<div>@@ -2446,6 +2445,15 @@ vlc_player_GetStatistics(vlc_player_t *player);<br></div>
<div> VLC_API void<br></div>
<div> vlc_player_SetPauseOnCork(vlc_player_t *player, bool enabled);<br></div>
<div> <br></div>
<div>+/**<br></div>
<div>+ * Set a video splitter to all vouts and all future vouts<br></div>
<div>+ *<br></div>
<div>+ * @param player locked instance<br></div>
<div>+ * @param splitter a video splitter name or NULL<br></div>
<div>+ */<br></div>
<div>+VLC_API void<br></div>
<div>+vlc_player_SetVideoSplitter(vlc_player_t *player, const char *splitter);<br></div>
<div>+<br></div>
<div> /**<br></div>
<div>  * Get the audio output<br></div>
<div>  *<br></div>
<div>diff --git a/src/input/player.c b/src/input/player.c<br></div>
<div>index 59d2fdb774..3609c5962f 100644<br></div>
<div>--- a/src/input/player.c<br></div>
<div>+++ b/src/input/player.c<br></div>
<div>@@ -3352,6 +3352,15 @@ vlc_player_vout_TriggerOption(vlc_player_t *player, const char *option)<br></div>
<div>     free(vouts);<br></div>
<div> }<br></div>
<div> <br></div>
<div>+void<br></div>
<div>+vlc_player_SetVideoSplitter(vlc_player_t *player, const char *splitter)<br></div>
<div>+{<br></div>
<div>+    vlc_player_assert_locked(player);<br></div>
<div>+    vlc_player_vout_SetVar(player, "video-splitter", VLC_VAR_STRING,<br></div>
<div>+                           (vlc_value_t) { .psz_string = (char *) splitter });<br></div>
<div>+    vlc_player_RestartTrackCategory(player, VIDEO_ES);<br></div>
<div>+}<br></div>
<div>+<br></div>
<div> void<br></div>
<div> vlc_player_vout_SetFullscreen(vlc_player_t *player, bool enabled)<br></div>
<div> {<br></div>
<div>@@ -3379,8 +3388,6 @@ vlc_vout_filter_type_to_varname(enum vlc_vout_filter_type type)<br></div>
<div> {<br></div>
<div>     switch (type)<br></div>
<div>     {<br></div>
<div>-        case VLC_VOUT_FILTER_VIDEO_SPLITTER:<br></div>
<div>-            return "video-splitter";<br></div>
<div>         case VLC_VOUT_FILTER_VIDEO_FILTER:<br></div>
<div>             return "video-filter";<br></div>
<div>         case VLC_VOUT_FILTER_SUB_SOURCE:<br></div>
<div>diff --git a/src/libvlccore.sym b/src/libvlccore.sym<br></div>
<div>index 9423e2fc20..d4db4ccc51 100644<br></div>
<div>--- a/src/libvlccore.sym<br></div>
<div>+++ b/src/libvlccore.sym<br></div>
<div>@@ -883,6 +883,7 @@ vlc_player_SetSubtitleSync<br></div>
<div> vlc_player_SetTeletextEnabled<br></div>
<div> vlc_player_SetTeletextTransparency<br></div>
<div> vlc_player_SetTrackCategoryEnabled<br></div>
<div>+vlc_player_SetVideoSplitter<br></div>
<div> vlc_player_Start<br></div>
<div> vlc_player_Stop<br></div>
<div> vlc_player_title_list_GetAt<br></div>
</pre></blockquote></div>
<div><br></div>
<div>-- <br></div>
<div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div>
<div><u>_______________________________________________</u><br></div>
<div>vlc-devel mailing list<br></div>
<div>To unsubscribe or modify your subscription options:<br></div>
<div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div>
</blockquote><div><br></div>
</body>
</html>