<div dir="auto">Hi Hugo,<br><br><div data-smartmail="gmail_signature" dir="auto"><br></div><br><div class="gmail_quote" dir="auto"><div dir="ltr">On Thu, Dec 13, 2018, 07:54 Hugo Beauzée-Luyssen <<a href="mailto:hugo@beauzee.fr">hugo@beauzee.fr</a> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Jun 30, 2016, at 8:18 AM, Sean McGovern wrote:<br>
> vlc | branch: master | Sean McGovern <<a href="mailto:gseanmcg@gmail.com" target="_blank" rel="noreferrer">gseanmcg@gmail.com</a>> | Wed Jun 29 <br>
> 15:31:03 2016 -0400| [fda25b9eca68e65a5de4966be8e9d29f00f232a0] | <br>
> committer: Jean-Baptiste Kempf<br>
> <br>
> contrib/gnutls: add libidn CFLAGS as appropriate<br>
> <br>
> The configury for gnutls already probes for this, but does not use<br>
> the values it finds.<br>
> <br>
> Signed-off-by: Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org" target="_blank" rel="noreferrer">jb@videolan.org</a>><br>
> <br>
> > <a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fda25b9eca68e65a5de4966be8e9d29f00f232a0" rel="noreferrer noreferrer" target="_blank">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fda25b9eca68e65a5de4966be8e9d29f00f232a0</a><br>
> ---<br>
> <br>
> contrib/src/gnutls/gnutls-libidn.patch | 36 ++++++++++++++++++++++++++++++++<br>
> contrib/src/gnutls/rules.mak | 1 +<br>
> 2 files changed, 37 insertions(+)<br>
> <br>
> diff --git a/contrib/src/gnutls/gnutls-libidn.patch b/contrib/src/<br>
> gnutls/gnutls-libidn.patch<br>
> new file mode 100644<br>
> index 0000000..5f00fa6<br>
> --- /dev/null<br>
> +++ b/contrib/src/gnutls/gnutls-libidn.patch<br>
> @@ -0,0 +1,36 @@<br>
> +--- gnutls/lib/x509/Makefile.am.ORIG Tue Jul 21 05:42:08 2015<br>
> ++++ gnutls/lib/x509/Makefile.am Wed Jun 29 15:05:35 2016<br>
> +@@ -23,7 +23,8 @@<br>
> + -I$(srcdir)/../includes \<br>
> + -I$(builddir)/../includes \<br>
> + -I$(srcdir)/.. \<br>
> +- $(LIBOPENCDK_CFLAGS)<br>
> ++ $(LIBOPENCDK_CFLAGS) \<br>
> ++ $(LIBIDN_CFLAGS)<br>
> + <br>
> + if ENABLE_MINITASN1<br>
> + AM_CPPFLAGS += -I$(srcdir)/../minitasn1<br>
> +--- gnutls/lib/ext/Makefile.am.ORIG Wed Feb 4 23:35:05 2015<br>
> ++++ gnutls/lib/ext/Makefile.am Wed Jun 29 15:19:34 2016<br>
> +@@ -26,7 +26,8 @@<br>
> + -I$(builddir)/../includes \<br>
> + -I$(builddir)/../../gl \<br>
> + -I$(srcdir)/.. \<br>
> +- -I$(srcdir)/../opencdk<br>
> ++ -I$(srcdir)/../opencdk \<br>
> ++ $(LIBIDN_CFLAGS)<br>
> + <br>
> + if ENABLE_MINITASN1<br>
> + AM_CPPFLAGS += -I$(srcdir)/../minitasn1<br>
> +--- gnutls/src/Makefile.am.ORIG Fri Jan 8 04:10:34 2016<br>
> ++++ gnutls/src/Makefile.am Wed Jun 29 15:20:12 2016<br>
> +@@ -41,7 +41,8 @@<br>
> + -I$(srcdir)/../lib/includes \<br>
> + -I$(srcdir)/../libdane/includes \<br>
> + -I$(srcdir)/../extra/includes \<br>
> +- $(LIBOPTS_CFLAGS)<br>
> ++ $(LIBOPTS_CFLAGS) \<br>
> ++ $(LIBIDN_CFLAGS)<br>
> + <br>
> + if NEED_LIBOPTS<br>
> + LIBOPTS = libopts/<a href="http://libopts.la" rel="noreferrer noreferrer" target="_blank">libopts.la</a><br>
> diff --git a/contrib/src/gnutls/rules.mak b/contrib/src/gnutls/rules.mak<br>
> index 85d3a49..912f508 100644<br>
> --- a/contrib/src/gnutls/rules.mak<br>
> +++ b/contrib/src/gnutls/rules.mak<br>
> @@ -35,6 +35,7 @@ endif<br>
> ifdef HAVE_MACOSX<br>
> $(APPLY) $(SRC)/gnutls/gnutls-pkgconfig-osx.patch<br>
> endif<br>
> + $(APPLY) $(SRC)/gnutls/gnutls-libidn.patch<br>
> $(call pkg_static,"lib/<a href="http://gnutls.pc.in" rel="noreferrer noreferrer" target="_blank">gnutls.pc.in</a>")<br>
> $(UPDATE_AUTOCONFIG)<br>
> $(MOVE)<br>
> <br>
<br>
Hi,<br>
<br>
Is this patch still required? I can build gnutls fine for windows/windows store/android without it.<br><br>
Regards,<br>
<br>
-- <br>
Hugo Beauzée-Luyssen<br>
<a href="mailto:hugo@beauzee.fr" target="_blank" rel="noreferrer">hugo@beauzee.fr</a><br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div><div dir="auto"><br></div><div dir="auto">When I originally wrote that patch I was still supporting the now defunct Solaris build, but I seem to remember it may have helped for MacOS as well. I won't have time to confirm soon -- maybe someone else can help here? David? Felix?</div><div dir="auto"><br></div><div dir="auto">If it is still important we could submit it upstream.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto"><br></div><div dir="auto">Sean McG.</div><div class="gmail_quote" dir="auto"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div>