<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Sean, Hugo,<div class=""><br class=""></div><div class="">Currently, on macOS libidn is not found by the configure script of gnutls, as it is not available. Therefore, I believe this patch currently does not have much effect on macOS builds.</div><div class=""><br class=""></div><div class="">However, I would assume support for IDNA would be desirable. Is this library present on windows or android platforms by default?</div><div class=""><br class=""></div><div class="">Best regards,</div><div class="">David<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 13.12.2018 um 22:26 schrieb Sean McGovern <<a href="mailto:gseanmcg@gmail.com" class="">gseanmcg@gmail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><div dir="auto" class="">Hi Hugo,<br class=""><br class=""><div data-smartmail="gmail_signature" dir="auto" class=""><br class=""></div><br class=""><div class="gmail_quote" dir="auto"><div dir="ltr" class="">On Thu, Dec 13, 2018, 07:54 Hugo Beauzée-Luyssen <<a href="mailto:hugo@beauzee.fr" class="">hugo@beauzee.fr</a> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Thu, Jun 30, 2016, at 8:18 AM, Sean McGovern wrote:<br class="">
> vlc | branch: master | Sean McGovern <<a href="mailto:gseanmcg@gmail.com" target="_blank" rel="noreferrer" class="">gseanmcg@gmail.com</a>> | Wed Jun 29 <br class="">
> 15:31:03 2016 -0400| [fda25b9eca68e65a5de4966be8e9d29f00f232a0] | <br class="">
> committer: Jean-Baptiste Kempf<br class="">
> <br class="">
> contrib/gnutls: add libidn CFLAGS as appropriate<br class="">
> <br class="">
> The configury for gnutls already probes for this, but does not use<br class="">
> the values it finds.<br class="">
> <br class="">
> Signed-off-by: Jean-Baptiste Kempf <<a href="mailto:jb@videolan.org" target="_blank" rel="noreferrer" class="">jb@videolan.org</a>><br class="">
> <br class="">
> > <a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fda25b9eca68e65a5de4966be8e9d29f00f232a0" rel="noreferrer noreferrer" target="_blank" class="">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fda25b9eca68e65a5de4966be8e9d29f00f232a0</a><br class="">
> ---<br class="">
> <br class="">
>  contrib/src/gnutls/gnutls-libidn.patch |   36 ++++++++++++++++++++++++++++++++<br class="">
>  contrib/src/gnutls/rules.mak           |    1 +<br class="">
>  2 files changed, 37 insertions(+)<br class="">
> <br class="">
> diff --git a/contrib/src/gnutls/gnutls-libidn.patch b/contrib/src/<br class="">
> gnutls/gnutls-libidn.patch<br class="">
> new file mode 100644<br class="">
> index 0000000..5f00fa6<br class="">
> --- /dev/null<br class="">
> +++ b/contrib/src/gnutls/gnutls-libidn.patch<br class="">
> @@ -0,0 +1,36 @@<br class="">
> +--- gnutls/lib/x509/Makefile.am.ORIG Tue Jul 21 05:42:08 2015<br class="">
> ++++ gnutls/lib/x509/Makefile.am      Wed Jun 29 15:05:35 2016<br class="">
> +@@ -23,7 +23,8 @@<br class="">
> +     -I$(srcdir)/../includes         \<br class="">
> +     -I$(builddir)/../includes       \<br class="">
> +     -I$(srcdir)/..                  \<br class="">
> +-    $(LIBOPENCDK_CFLAGS)<br class="">
> ++    $(LIBOPENCDK_CFLAGS)            \<br class="">
> ++    $(LIBIDN_CFLAGS)<br class="">
> + <br class="">
> + if ENABLE_MINITASN1<br class="">
> + AM_CPPFLAGS += -I$(srcdir)/../minitasn1<br class="">
> +--- gnutls/lib/ext/Makefile.am.ORIG  Wed Feb  4 23:35:05 2015<br class="">
> ++++ gnutls/lib/ext/Makefile.am       Wed Jun 29 15:19:34 2016<br class="">
> +@@ -26,7 +26,8 @@<br class="">
> +     -I$(builddir)/../includes       \<br class="">
> +     -I$(builddir)/../../gl          \<br class="">
> +     -I$(srcdir)/..                  \<br class="">
> +-    -I$(srcdir)/../opencdk<br class="">
> ++    -I$(srcdir)/../opencdk          \<br class="">
> ++    $(LIBIDN_CFLAGS)<br class="">
> + <br class="">
> + if ENABLE_MINITASN1<br class="">
> + AM_CPPFLAGS += -I$(srcdir)/../minitasn1<br class="">
> +--- gnutls/src/Makefile.am.ORIG      Fri Jan  8 04:10:34 2016<br class="">
> ++++ gnutls/src/Makefile.am   Wed Jun 29 15:20:12 2016<br class="">
> +@@ -41,7 +41,8 @@<br class="">
> +     -I$(srcdir)/../lib/includes             \<br class="">
> +     -I$(srcdir)/../libdane/includes         \<br class="">
> +     -I$(srcdir)/../extra/includes   \<br class="">
> +-    $(LIBOPTS_CFLAGS)<br class="">
> ++    $(LIBOPTS_CFLAGS)               \<br class="">
> ++    $(LIBIDN_CFLAGS)<br class="">
> + <br class="">
> + if NEED_LIBOPTS<br class="">
> + LIBOPTS = libopts/<a href="http://libopts.la/" rel="noreferrer noreferrer" target="_blank" class="">libopts.la</a><br class="">
> diff --git a/contrib/src/gnutls/rules.mak b/contrib/src/gnutls/rules.mak<br class="">
> index 85d3a49..912f508 100644<br class="">
> --- a/contrib/src/gnutls/rules.mak<br class="">
> +++ b/contrib/src/gnutls/rules.mak<br class="">
> @@ -35,6 +35,7 @@ endif<br class="">
>  ifdef HAVE_MACOSX<br class="">
>       $(APPLY) $(SRC)/gnutls/gnutls-pkgconfig-osx.patch<br class="">
>  endif<br class="">
> +     $(APPLY) $(SRC)/gnutls/gnutls-libidn.patch<br class="">
>       $(call pkg_static,"lib/<a href="http://gnutls.pc.in/" rel="noreferrer noreferrer" target="_blank" class="">gnutls.pc.in</a>")<br class="">
>       $(UPDATE_AUTOCONFIG)<br class="">
>       $(MOVE)<br class="">
> <br class="">
<br class="">
Hi,<br class="">
<br class="">
Is this patch still required? I can build gnutls fine for windows/windows store/android without it.<br class=""><br class="">
Regards,<br class="">
<br class="">
-- <br class="">
  Hugo Beauzée-Luyssen<br class="">
  <a href="mailto:hugo@beauzee.fr" target="_blank" rel="noreferrer" class="">hugo@beauzee.fr</a><br class="">
_______________________________________________<br class="">
vlc-devel mailing list<br class="">
To unsubscribe or modify your subscription options:<br class="">
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank" class="">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">When I originally wrote that patch I was still supporting the now defunct Solaris build, but I seem to remember it may have helped for MacOS as well. I won't have time to confirm soon -- maybe someone else can help here? David? Felix?</div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">If it is still important we could submit it upstream.</div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">Thanks,</div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">Sean McG.</div><div class="gmail_quote" dir="auto"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote></div></div>
_______________________________________________<br class="">vlc-devel mailing list<br class="">To unsubscribe or modify your subscription options:<br class=""><a href="https://mailman.videolan.org/listinfo/vlc-devel" class="">https://mailman.videolan.org/listinfo/vlc-devel</a></div></blockquote></div><br class=""></div></body></html>