<html><head></head><body>This looks like a totally out of place ifdef kludge. And it seems trivial to avoid it by solving the problem in the existing Win32 support backend.<br><br>And it probably breaks cache assumptions.<br><br><div class="gmail_quote">Le 13 décembre 2018 14:11:02 GMT+02:00, Steve Lhomme <git@videolan.org> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">vlc | branch: master | Steve Lhomme <robux4@videolabs.io> | Fri Sep 30 09:49:19 2016 +0200| [3edd48f2ecac2471af0f00941b9e52948fca79e5] | committer: Steve Lhomme<br><br>plugin cache: Windows doesn't like relative pathes in LoadLibraryEx()<br><br>Fixes "vlc-cache-gen ../modules" on Windows and general VLC_PLUGIN_PATH usage.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3edd48f2ecac2471af0f00941b9e52948fca79e5">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3edd48f2ecac2471af0f00941b9e52948fca79e5</a><br></blockquote><hr> src/modules/bank.c | 4 ++++<br> 1 file changed, 4 insertions(+)<br><br>diff --git a/src/modules/bank.c b/src/modules/bank.c<br>index 331fdc40ca..a67c338a8b 100644<br>--- a/src/modules/bank.c<br>+++ b/src/modules/bank.c<br>@@ -474,7 +474,11 @@ static void AllocateAllPlugins (vlc_object_t *p_this)<br> if( paths == NULL )<br> return;<br> <br>+#ifdef _WIN32<br>+ paths = realpath( paths, NULL );<br>+#else<br> paths = strdup( paths ); /* don't harm the environment ! :) */<br>+#endif<br> if( unlikely(paths == NULL) )<br> return;<hr>vlc-commits mailing list<br>vlc-commits@videolan.org<br><a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>