<html><head></head><body>What value of c is treated differently? I cannot find such from a quick look. In fact, it looks to me that there are still some tautologies left in the code.<br><br><div class="gmail_quote">Le 21 janvier 2019 09:38:24 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 18/01/2019 17:51, Johan Gunnarsson wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> codec/cea708.c:1649:18: warning: variable 'i_ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]<br> else if( c > 0x9F )<br> ^~~~~~~~<br> codec/cea708.c:1652:13: note: uninitialized use occurs here<br> if( i_ret & CEA708_STATUS_OUTPUT )<br> ^~~~~<br> codec/cea708.c:1649:14: note: remove the 'if' if its condition is always true<br> else if( c > 0x9F )<br> ^~~~~~~~~~~~~~<br> codec/cea708.c:1640:18: note: initialize the variable 'i_ret' to silence this warning<br> int i_ret;<br> ^<br> = 0<br> 1 warning generated.<hr> modules/codec/cea708.c | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br><br> diff --git a/modules/codec/cea708.c b/modules/codec/cea708.c<br> index c0cea476f7..e56b8779ed 100644<br> --- a/modules/codec/cea708.c<br> +++ b/modules/codec/cea708.c<br> @@ -1642,11 +1642,11 @@ static void CEA708_Decode_ServiceBuffer( cea708_t *h )<br> <br> if( c < 0x20 )<br> i_ret = CEA708_Decode_C0( c, h );<br> - else if( c >= 0x20 && c <=0x7F )<br> + else if( c >= 0x20 && c <= 0x7F )<br> i_ret = CEA708_Decode_G0( c, h );<br> else if( c >= 0x80 && c <= 0x9F )<br> i_ret = CEA708_Decode_C1( c, h );<br> - else if( c > 0x9F )<br> + else<br> i_ret = CEA708_Decode_G1( c, h );<br></blockquote><br>This is not fixing a benign warning, it's changing the behavior of the <br>code as well. If c is neither of these values maybe i_ret should have an <br>error value.<br><br>> <br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> if( i_ret & CEA708_STATUS_OUTPUT )<br> -- <br> 2.17.1<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>