<html><head></head><body>The parameter was constant (false) where it was used, as it was the result of calloc()'ing the vout object. At that point, the interlacing flag just could not be set yet, since the vout had not seen any picture yet.<br><br>AFAIK, this changeset does not affect vout reinitialisation. There is a separate function for reinitialising the deinterlacing context.<br><br>Then again, I don't know if we should preserve the flag on reinit... It gets set for each picture anyway, so it really is a matter of which scenario to optimise for... Either progressive, or same as previous input.<br><br><br><div class="gmail_quote">Le 28 janvier 2019 10:30:04 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 26/01/2019 19:50, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> vlc | branch: master | Rémi Denis-Courmont <remi@remlab.net> | Thu Jan 24 22:43:11 2019 +0200| [e65a503f5bbe68e9a89efc73e39860a234afb520] | committer: Rémi Denis-Courmont<br><br> interlacing: remove constant parameter<br></blockquote><br>sys->displayed.is_interlaced is not constant. Maybe it was during <br>initialization, but now that there's a persistent configuration for the <br>display it should be in there and may not be false when reinitialized.<br><br>><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e65a503f5bbe68e9a89efc73e39860a234afb520">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e65a503f5bbe68e9a89efc73e39860a234afb520</a><br></blockquote><hr> src/video_output/interlacing.c | 8 ++------<br> src/video_output/interlacing.h | 2 +-<br> src/video_output/video_output.c | 2 +-<br> 3 files changed, 4 insertions(+), 8 deletions(-)<br><br> diff --git a/src/video_output/interlacing.c b/src/video_output/interlacing.c<br> index ace2ca84e9..3192b3a9cf 100644<br> --- a/src/video_output/interlacing.c<br> +++ b/src/video_output/interlacing.c<br> @@ -95,7 +95,7 @@ static int DeinterlaceCallback(vlc_object_t *object, char const *cmd,<br> return VLC_SUCCESS;<br> }<br> <br> -void vout_InitInterlacingSupport(vout_thread_t *vout, bool is_interlaced)<br> +void vout_InitInterlacingSupport(vout_thread_t *vout)<br> {<br> vlc_value_t val;<br> <br> @@ -155,15 +155,11 @@ void vout_InitInterlacingSupport(vout_thread_t *vout, bool is_interlaced)<br> /* */<br> val.psz_string = deinterlace_mode ? deinterlace_mode : optm->orig.psz;<br> var_Change(vout, "deinterlace-mode", VLC_VAR_SETVALUE, val);<br> - val.b_bool = is_interlaced;<br> - var_Change(vout, "deinterlace-needed", VLC_VAR_SETVALUE, val);<br> <br> var_SetInteger(vout, "deinterlace", deinterlace_state);<br> free(deinterlace_mode);<br> <br> - vout->p->interlacing.is_interlaced = is_interlaced;<br> - if (is_interlaced)<br> - vout->p->interlacing.date = vlc_tick_now();<br> + vout->p->interlacing.is_interlaced = false;<br> }<br> <br> void vout_ReinitInterlacingSupport(vout_thread_t *vout)<br> diff --git a/src/video_output/interlacing.h b/src/video_output/interlacing.h<br> index af117ce259..c8b4b65fe5 100644<br> --- a/src/video_output/interlacing.h<br> +++ b/src/video_output/interlacing.h<br> @@ -23,7 +23,7 @@<br> #ifndef LIBVLC_VOUT_INTERLACING_H<br> #define LIBVLC_VOUT_INTERLACING_H<br> <br> -void vout_InitInterlacingSupport(vout_thread_t *, bool is_interlaced);<br> +void vout_InitInterlacingSupport(vout_thread_t *);<br> void vout_ReinitInterlacingSupport(vout_thread_t *);<br> void vout_SetInterlacingState(vout_thread_t *, bool is_interlaced);<br> <br> diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c<br> index ba3b460c6b..a01a615201 100644<br> --- a/src/video_output/video_output.c<br> +++ b/src/video_output/video_output.c<br> @@ -158,7 +158,7 @@ static vout_thread_t *VoutCreate(vlc_object_t *object,<br> sys->title.timeout = var_InheritInteger(vout, "video-title-timeout");<br> sys->title.position = var_InheritInteger(vout, "video-title-position");<br> <br> - vout_InitInterlacingSupport(vout, sys->displayed.is_interlaced);<br> + vout_InitInterlacingSupport(vout);<br> <br> sys->is_late_dropped = var_InheritBool(vout, "drop-late-frames");<hr> vlc-commits mailing list<br> vlc-commits@videolan.org<br> <a href="https://mailman.videolan.org/listinfo/vlc-commits">https://mailman.videolan.org/listinfo/vlc-commits</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>