<html><head></head><body>Hi,<br><br>This patch does not change builds with explicitly enabled or disabled debug, AFAICT. So you don't need to remove --enable-debug anywhere.<br><br>I have no strong opinion for or against this change.<br><br><div class="gmail_quote">Le 7 février 2019 14:26:12 GMT+02:00, "Hugo Beauzée-Luyssen" <hugo@beauzee.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Thu, Feb 7, 2019, at 1:23 PM, Thomas Guillem wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">It seems that lot of developers forget to enable this option. This option<br>enables assert and other debug codes (like the very useful thread/mutex debug<br>code) that should be mandatory when you dev on VLC.<br><br>This is quite a big change: all VLC maintainers should now add<br>"--disable-debug" when they release a stable version of VLC.<hr> configure.ac | 6 +++---<br> 1 file changed, 3 insertions(+), 3 deletions(-)<br><br>diff --git a/configure.ac b/configure.ac<br>index 9453dd852b..4f4b6b395a 100644<br>--- a/configure.ac<br>+++ b/configure.ac<br>@@ -979,9 +979,9 @@ dnl<br> dnl Debugging mode<br> dnl<br> AC_ARG_ENABLE([debug],<br>- AS_HELP_STRING([--enable-debug],<br>- [build with run-time assertions (default disabled)]),,<br>- [enable_debug="no"])<br>+ AS_HELP_STRING([--disable-debug],<br>+ [build with run-time assertions (default enabled)]),,<br>+ [enable_debug="yes"])<br> AH_TEMPLATE(NDEBUG,<br> [Define to 1 if debug code should NOT be compiled])<br> AS_IF([test "${enable_debug}" != "no"], [<br></blockquote><br>I like the idea, but this implies we go through all our build scripts (for instance, the win32 one uses --enable-debug) and adjust accordingly.<br>Regardless of the patch being applied or not, we might want to explicitly tweak those scripts to explicitly provide --enable/--disable-debug.<br></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>