<div dir="auto"><span style="font-family:sans-serif">Hi</span><div dir="auto" style="font-family:sans-serif"><br></div><div dir="auto" style="font-family:sans-serif">You are saying that macos or qt code should be used to handle the fullscreen bug right?</div><div dir="auto" style="font-family:sans-serif"><br></div><div dir="auto" style="font-family:sans-serif">Here is the issue  documented: <a href="https://forum.videolan.org/viewtopic.php?t=146196">https://forum.videolan.org/viewtopic.php?t=146196</a></div><div dir="auto" style="font-family:sans-serif"><br></div><div dir="auto" style="font-family:sans-serif">I did not understand your previous mail fully please comment whenever you have time</div><div dir="auto" style="font-family:sans-serif"><br></div><div dir="auto" style="font-family:sans-serif">Thanks</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, 5 Feb 2019, 13:12 Steve Lhomme, <<a href="mailto:robux4@ycbcr.xyz">robux4@ycbcr.xyz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
This is not how key mapping should work. Looking at the code the Qt and <br>
OS X interfaces both handle the boss key event. If you want to handle <br>
the fullscreen it should be done there. But looking at the code using <br>
the boss key twice gets back to the previous state. That's not what your <br>
code does.<br>
<br>
Also what is currently unreliable ?<br>
<br>
On 04/02/2019 20:08, Vikalp Bhandari <a href="mailto:97vikalp@gmail.com" target="_blank" rel="noreferrer">97vikalp@gmail.com</a> wrote:<br>
> turn off fullscreen before triggering callback<br>
> ---<br>
>   modules/control/hotkeys.c | 3 +++<br>
>   1 file changed, 3 insertions(+)<br>
><br>
> diff --git a/modules/control/hotkeys.c b/modules/control/hotkeys.c<br>
> index 6c60deaf09..533ff7df5a 100644<br>
> --- a/modules/control/hotkeys.c<br>
> +++ b/modules/control/hotkeys.c<br>
> @@ -401,6 +401,9 @@ static int PutAction( intf_thread_t *p_intf, input_thread_t *p_input,<br>
>               var_TriggerCallback( p_playlist, "intf-toggle-fscontrol" );<br>
>               break;<br>
>           case ACTIONID_INTF_BOSS:<br>
> +            if( p_vout )<br>
> +                var_SetBool( p_vout, "fullscreen", false );<br>
> +            var_SetBool( p_playlist, "fullscreen", false );<br>
>               var_TriggerCallback( p_playlist, "intf-boss" );<br>
>               break;<br>
>           case ACTIONID_INTF_POPUP_MENU:<br>
> -- <br>
> 2.17.1<br>
><br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>