<!doctype html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body>Not necessarily. You could miss some flags as a result of discarding an empty block.<br><br><div class="gmail_quote">Le 12 février 2019 13:37:56 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div><div>On Tue, Feb 12, 2019, at 12:25, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="fastmail-quoted"><div>We never really specified whether or when a block could be empty, so you can't really say it's a bug in the source rather than the sink.<br></div></blockquote><div><br></div><div>Yes, but do we agree that is useless to try to play them ?<br></div><div><br></div><blockquote type="cite" id="fastmail-quoted"><div><br></div><div class="fastmail-quoted-gmail_quote"><div>Le 12 février 2019 11:02:31 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="fastmail-quoted-gmail_quote"><pre class="fastmail-quoted-k9mail"><div>Other possible fix: put an assert and fix the filters that send empty blocks.<hr> src/audio_output/dec.c | 5 +++++<br></div><div> 1 file changed, 5 insertions(+)<br></div><div><br></div><div>diff --git a/src/audio_output/dec.c b/src/audio_output/dec.c<br></div><div>index b913ac18a0..e5aff4f691 100644<br></div><div>--- a/src/audio_output/dec.c<br></div><div>+++ b/src/audio_output/dec.c<br></div><div>@@ -370,6 +370,11 @@ int aout_DecPlay(audio_output_t *aout, block_t *block)<br></div><div> block = aout_FiltersPlay(owner->filters, block, owner->sync.rate);<br></div><div> if (block == NULL)<br></div><div> goto lost;<br></div><div>+ else if (unlikely(block->i_buffer == 0))<br></div><div>+ {<br></div><div>+ block_Release(block);<br></div><div>+ return ret;<br></div><div>+ }<br></div><div> <br></div><div> /* Software volume */<br></div><div> aout_volume_Amplify (owner->volume, block);<br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>