<html><head></head><body>Hi,<br><br>Even with pull-buffers, I don't see any justification for pool lock/unlock. If you don't want a certain picture buffer to be "locked", just keep it held. Only release the picture buffer once it is ready to be reused.<br><br><div class="gmail_quote">Le 26 février 2019 10:34:28 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 25/02/2019 16:53, Thomas Guillem wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">I prefer that you don't touch android for now. It's OK to break the VLC4.0 Android build, it is regularly broken and not tested/used by the vlc-android app.<br></blockquote><br>I'm not entirely sure we can get rid of the lock in pools yet so I don't <br>think I will push for now. It will also break MMAL support. I don't know <br>if some bots build that and if it's OK to break it or even remove it (it <br>would need a bit of cleaning up and adapting if we get rid of all the <br>"external" display pools).<br><br>><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">On Mon, Feb 25, 2019, at 15:49, Steve Lhomme wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Not sure if decoding will still work if the pictures are unlocked by default<br> during decoding.<br> This pool will probably move in the decoder anyway. The unlock/lock might have<br> to be done in the Display() if displaying locked pictures is not possible.<hr> modules/video_output/android/display.c | 9 ++++-----<br> 1 file changed, 4 insertions(+), 5 deletions(-)<br><br> diff --git a/modules/video_output/android/display.c<br> b/modules/video_output/android/display.c<br> index 73767fcd09..e0f45109b0 100644<br> --- a/modules/video_output/android/display.c<br> +++ b/modules/video_output/android/display.c<br> @@ -794,10 +794,8 @@ static picture_pool_t *PoolAlloc(vout_display_t<br> *vd, unsigned requested_count)<br> pp_pics[i] = p_pic;<br> }<br> <br> - picture_pool_configuration_t pool_cfg;<br> - memset(&pool_cfg, 0, sizeof(pool_cfg));<br> - pool_cfg.picture_count = requested_count;<br> - pool_cfg.picture = pp_pics;<br> +#if 0<br> + /* we could do the lock/copy/unlock in Prepare() */<br> if (sys->p_window->b_opaque)<br> {<br> pool_cfg.lock = PoolLockOpaquePicture;<br> @@ -808,7 +806,8 @@ static picture_pool_t *PoolAlloc(vout_display_t<br> *vd, unsigned requested_count)<br> pool_cfg.lock = PoolLockPicture;<br> pool_cfg.unlock = PoolUnlockPicture;<br> }<br> - pool = picture_pool_NewExtended(&pool_cfg);<br> +#endif<br> + pool = picture_pool_New(requested_count, pp_pics);<br> <br> error:<br> if (!pool && pp_pics) {<br> -- <br> 2.17.1<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>