<!doctype html><html><head><title></title><style type="text/css">#fastmail-quoted #fastmail-quoted-fastmail-quoted p.fastmail-quoted-fastmail-quoted-MsoNormal,#fastmail-quoted #fastmail-quoted-fastmail-quoted p.fastmail-quoted-fastmail-quoted-MsoNoSpacing{margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;}
#fastmail-quoted p.fastmail-quoted-MsoNormal,#fastmail-quoted p.fastmail-quoted-MsoNoSpacing{margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body>Hi,<br><br>There is no such thing as absolute thread safety, except for trivial useless constructs.<br><br>Accessing object variables, flags and logger for an object whose nature and ownership is known may be safe, e.g. getting input or output objects from playlist.<br><br>Accessing an unknown object is not. As already noted, variables, logging and flags are not thread-safe in the general case. Besides, how do you get to that object in the first place? You cannot safely manifest a reference out of thin air.<br><br><div class="gmail_quote">Le 5 mars 2019 11:35:05 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><br></div><div>On Tue, Mar 5, 2019, at 10:28, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="fastmail-quoted"><div>I don't mean "you" as just your individuality as opposed to the group. I mean you as in the group including you, as opposed to the group excluding you (because you weren't there, or hypothetically because you'd left).<br></div><div><br></div><div>And I have been disentangling VLC object and fixing threads for over a decade (quite often they are two sides of the same coin). I am not the least bit interested in giving up so close. But if the tech commitee out-votes me, I will stop caring.<br></div><div><br></div><div>I wouldn't want to be using a thread sanitizer if this happens though. In fact, I don't think I would want to use VLC on an SMP system at all.<br></div></blockquote><div><br></div><div>Why ? VLC object variables are thread safe, no ? There is just a TOCTOU issue. I guess that's OK if it's used only for debugging.<br></div><div><br></div><blockquote type="cite" id="fastmail-quoted"><div><br></div><div class="fastmail-quoted-gmail_quote"><div>Le 5 mars 2019 11:12:52 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="fastmail-quoted-gmail_quote"><div>On Tue, Mar 5, 2019, at 10:02, Rémi Denis-Courmont wrote:<br></div><blockquote id="fastmail-quoted-fastmail-quoted" type="cite"><div>Yeah. And we never agreed to un-deprecate object names and allow them to be used by plugins back again. And I did even remind of the deprecation at the last workshop less than two weeks ago - not exactly a surprise.<br></div></blockquote><div><br></div><div>We didn't decided to break the QT module dialog. This feature is very very useful for user support, I don't think we can't ride of it.<br></div><div><br></div><div>And yes, It happens to me a lot: I decide to a technical solution, I try to implement it and I encounter something I didn't planned.<br></div><div><br></div><div>For me, module_t still need to be tied to vlc_object_t<br></div><div><br></div><blockquote id="fastmail-quoted-fastmail-quoted" type="cite"><div><br></div><div>What you want is that all changes are agreed upon by you. That's not what we agreed.<br></div></blockquote><div><br></div><div>Not me, but us. If developers that are doing a lot more user support than me (Francois, Steve, Hugo and JB) agree to kill the QT module dialog, I won't be against the common decision.<br></div><div><br></div><blockquote id="fastmail-quoted-fastmail-quoted" type="cite"><div><br></div><div class="fastmail-quoted-fastmail-quoted-gmail_quote"><div>Le 5 mars 2019 10:48:21 GMT+02:00, Thomas Guillem <thomas@gllm.fr> a écrit :<br></div><blockquote class="fastmail-quoted-fastmail-quoted-gmail_quote" style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;"><div>On Tue, Mar 5, 2019, at 09:43, Rémi Denis-Courmont wrote:<br></div><blockquote type="cite" id="fastmail-quoted-fastmail-quoted-fastmail-quoted"><div>No. I am not accountable for bugs pushed by Antoine (object names), the other Rémi (Qt objects tree) and François (adding code using a feature that's already deprecated and of course without review).<br></div></blockquote><div><br></div><div>And that is why, we decided to always go to the mailing list when we add/remove new features or modify the VLC/LibVLC core API. It's useless to lament on what was done on the past or find a culprit for bad things that were done a *long* time ago.<br></div><div><br></div><blockquote type="cite" id="fastmail-quoted-fastmail-quoted-fastmail-quoted"><div><br></div><div>Unlike you, I have spent days trying to fix these things with variable success. And now, you are preventing me from fixing that for good.<br></div><div><br></div><div>So if somebody's accountable, it's you.<br></div><div><br></div><div class="fastmail-quoted-fastmail-quoted-fastmail-quoted-gmail_quote"><div>Le 5 mars 2019 10:17:34 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:0pt;margin-left:0.8ex;border-left-color:rgb(204, 204, 204);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="fastmail-quoted-fastmail-quoted-fastmail-quoted-gmail_quote"><pre class="fastmail-quoted-fastmail-quoted-fastmail-quoted-k9mail"><div>On 3/5/2019 8:52 AM, Rémi Denis-Courmont wrote:<br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="fastmail-quoted-fastmail-quoted-fastmail-quoted-gmail_quote"><div>I am not going to hold your hand running git-log or git-blame. The <br></div><div>facts are there, you just don't care to look for them preferring to <br></div><div>band against me.<br></div></blockquote><div><br></div><div>You're accountable for the things you push on VLC just like the rest of <br></div><div>us. If people disagree with a change you made without discussing you <br></div><div>have to explain why, just like the rest of us. Saying it was already <br></div><div>discussed 10 years ago (as a flamewar, so definitely not in the SVN <br></div><div>logs) with other people is not a way to collaborate.<br></div><div><br></div><div>><br></div><blockquote style="margin-top:0pt;margin-right:0pt;margin-bottom:1ex;margin-left:0.8ex;border-left-color:rgb(114, 159, 207);border-left-style:solid;border-left-width:1px;padding-left:1ex;" class="fastmail-quoted-fastmail-quoted-fastmail-quoted-gmail_quote"><div> And it's not exactly rocket science that introspection does not work <br></div><div> across threads - in general, not just in VLC.<br></div><div><br></div><div> Le 5 mars 2019 09:03:43 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a <br></div><div> écrit :<br></div><div><br></div><div> On 3/4/2019 9:51 PM, Rémi Denis-Courmont wrote:<br></div><div><br></div><div> Decreeing that discussions older than 3 is irrelevant is<br></div><div> ridiculous. <br></div><div><br></div><div><br></div><div> Yes and no. Valid points many years ago are likely to be valid today.<br></div><div> But if we're not presented with them there is no way to know. The code<br></div><div> has changed a lot in the last few years and will continue to do so. Some<br></div><div> things that used to be true may not be anymore and vice versa. But we<br></div><div> need the facts, not "it was discussed 9 years ago, end of discussion".<hr> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div><div><br></div><div><br></div><div> -- <br></div><div> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez <br></div><div> excuser ma brièveté.<hr> vlc-devel mailing list<br></div><div> To unsubscribe or modify your subscription options:<br></div><div> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></blockquote><div><hr>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></div></pre></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><div><br></div><div>-- <br></div><div>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. <br></div><div>_______________________________________________<br></div><div>vlc-devel mailing list<br></div><div>To unsubscribe or modify your subscription options:<br></div><div>https://mailman.videolan.org/listinfo/vlc-devel<br></div></blockquote><div><br></div></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>