<html><head></head><body>Hi,<br><br>I'm not sure that "uses forbidden API" is a good reason for disabling. If it provides features for which there are no alternatives, this goes against the plays-it-all branding, AFAICT.<br><br>Sounds more like patching or wrapping is needed. But no objections.<br><br><div class="gmail_quote">Le 5 mars 2019 14:17:28 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">- SDL_image : uses forbidden APIs<br>- aribb25 : uses forbidden APIs<br>- bluray : missing JAVA on UWP<br>- caca : no console (may change in the future)<br>- cddb : no disc access (may change in the future)<br>- d3d9 : no access to D3D9 on store supported OSes<br>- gettext : not supported and uses forbidden APIs<br>- glslang : not supported<br>- mfx : needs an update to build properly<br>- modplug : uses forbidden APIs<br>- projectM : uses forbidden APIs<br>- qt : not used in our winstore build and likely won't build (could be removed when selecting a libvlc only build)<br>- qtdeclarative : same as qt<br>- qtgraphicaleffects : same as qt<br>- qtquickcontrols2 : same as qt<br>- qtsvg : same as qt<br>- sdl : uses forbidden APIs<br>- srt : uses forbidden APIs<br>- vncclient : uses forbidden APIs<hr> contrib/src/SDL_image/rules.mak | 2 ++<br> contrib/src/aribb25/rules.mak | 2 ++<br> contrib/src/bluray/rules.mak | 2 ++<br> contrib/src/caca/rules.mak | 2 ++<br> contrib/src/cddb/rules.mak | 2 ++<br> contrib/src/d3d9/rules.mak | 2 +-<br> contrib/src/gettext/rules.mak | 2 ++<br> contrib/src/glslang/rules.mak | 2 ++<br> contrib/src/mfx/rules.mak | 2 ++<br> contrib/src/modplug/rules.mak | 2 ++<br> contrib/src/projectM/rules.mak | 2 ++<br> contrib/src/qt/rules.mak | 2 ++<br> contrib/src/qtdeclarative/rules.mak | 2 ++<br> contrib/src/qtgraphicaleffects/rules.mak | 2 ++<br> contrib/src/qtquickcontrols2/rules.mak | 2 ++<br> contrib/src/qtsvg/rules.mak | 2 ++<br> contrib/src/sdl/rules.mak | 2 ++<br> contrib/src/srt/rules.mak | 2 ++<br> contrib/src/vncclient/rules.mak | 2 ++<br> 19 files changed, 37 insertions(+), 1 deletion(-)<br><br>diff --git a/contrib/src/SDL_image/rules.mak b/contrib/src/SDL_image/rules.mak<br>index c66911ac78..072463493a 100644<br>--- a/contrib/src/SDL_image/rules.mak<br>+++ b/contrib/src/SDL_image/rules.mak<br>@@ -3,7 +3,9 @@<br> SDL_IMAGE_VERSION := 1.2.12<br> SDL_IMAGE_URL := <a href="http://www.libsdl.org/projects/SDL_image/release/SDL_image-$(SDL_IMAGE_VERSION).tar.gz">http://www.libsdl.org/projects/SDL_image/release/SDL_image-$(SDL_IMAGE_VERSION).tar.gz</a><br> <br>+ifndef HAVE_WINSTORE<br> PKGS += SDL_image<br>+endif<br> ifeq ($(call need_pkg,"SDL_image"),)<br> PKGS_FOUND += SDL_image<br> endif<br>diff --git a/contrib/src/aribb25/rules.mak b/contrib/src/aribb25/rules.mak<br>index bc1ef48933..7bcd9b3e03 100644<br>--- a/contrib/src/aribb25/rules.mak<br>+++ b/contrib/src/aribb25/rules.mak<br>@@ -4,8 +4,10 @@ ARIBB25_VERSION := 0.2.7<br> ARIBB25_URL := $(VIDEOLAN)/aribb25/$(ARIBB25_VERSION)/aribb25-$(ARIBB25_VERSION).tar.gz<br> <br> ifdef HAVE_WIN32<br>+ifndef HAVE_WINSTORE<br> PKGS += aribb25<br> endif<br>+endif<br> ifeq ($(call need_pkg,"pcslite"),)<br> PKGS += aribb25<br> endif<br>diff --git a/contrib/src/bluray/rules.mak b/contrib/src/bluray/rules.mak<br>index 09ad2f43f6..0e07128c45 100644<br>--- a/contrib/src/bluray/rules.mak<br>+++ b/contrib/src/bluray/rules.mak<br>@@ -4,8 +4,10 @@ BLURAY_VERSION := 1.1.0<br> BLURAY_URL := $(VIDEOLAN)/libbluray/$(BLURAY_VERSION)/libbluray-$(BLURAY_VERSION).tar.bz2<br> <br> ifdef BUILD_DISCS<br>+ifndef HAVE_WINSTORE<br> PKGS += bluray<br> endif<br>+endif<br> ifeq ($(call need_pkg,"libbluray >= 0.7.0"),)<br> PKGS_FOUND += bluray<br> endif<br>diff --git a/contrib/src/caca/rules.mak b/contrib/src/caca/rules.mak<br>index 2bc78d893e..6369d1ec5c 100644<br>--- a/contrib/src/caca/rules.mak<br>+++ b/contrib/src/caca/rules.mak<br>@@ -3,8 +3,10 @@ CACA_VERSION := 0.99.beta17<br> CACA_URL := <a href="http://caca.zoy.org/files/libcaca/libcaca-$(CACA_VERSION).tar.gz">http://caca.zoy.org/files/libcaca/libcaca-$(CACA_VERSION).tar.gz</a><br> <br> ifndef HAVE_LINUX # see VLC Trac 17251<br>+ifndef HAVE_WINSTORE<br> PKGS += caca<br> endif<br>+endif<br> ifeq ($(call need_pkg,"caca >= 0.99.beta14"),)<br> PKGS_FOUND += caca<br> endif<br>diff --git a/contrib/src/cddb/rules.mak b/contrib/src/cddb/rules.mak<br>index e317152812..c9da6d7b83 100644<br>--- a/contrib/src/cddb/rules.mak<br>+++ b/contrib/src/cddb/rules.mak<br>@@ -4,9 +4,11 @@ CDDB_URL := $(SF)/libcddb/libcddb-$(CDDB_VERSION).tar.bz2<br> <br> ifdef BUILD_NETWORK<br> ifdef BUILD_DISCS<br>+ifndef HAVE_WINSTORE<br> PKGS += cddb<br> endif<br> endif<br>+endif<br> ifeq ($(call need_pkg,"libcddb"),)<br> PKGS_FOUND += cddb<br> endif<br>diff --git a/contrib/src/d3d9/rules.mak b/contrib/src/d3d9/rules.mak<br>index b3b3b61aea..d2fd57c3a5 100644<br>--- a/contrib/src/d3d9/rules.mak<br>+++ b/contrib/src/d3d9/rules.mak<br>@@ -18,7 +18,7 @@ DST_DXVA2API_H = $(PREFIX)/include/dxva2api.h<br> <br> <br> ifdef HAVE_WIN32<br>-ifndef HAVE_VISUALSTUDIO<br>+ifndef HAVE_WINSTORE<br> PKGS += d3d9<br> endif<br> endif<br>diff --git a/contrib/src/gettext/rules.mak b/contrib/src/gettext/rules.mak<br>index 2684b8ff5e..8e8dbbebaa 100644<br>--- a/contrib/src/gettext/rules.mak<br>+++ b/contrib/src/gettext/rules.mak<br>@@ -2,7 +2,9 @@<br> GETTEXT_VERSION := 0.19.8.1<br> GETTEXT_URL := $(GNU)/gettext/gettext-$(GETTEXT_VERSION).tar.gz<br> <br>+ifndef HAVE_WINSTORE<br> PKGS += gettext<br>+endif<br> ifneq ($(filter gnu%,$(subst -, ,$(HOST))),)<br> # GNU platform should have gettext (?)<br> PKGS_FOUND += gettext<br>diff --git a/contrib/src/glslang/rules.mak b/contrib/src/glslang/rules.mak<br>index 5b60a5ab1c..9c6ab12cc7 100644<br>--- a/contrib/src/glslang/rules.mak<br>+++ b/contrib/src/glslang/rules.mak<br>@@ -4,7 +4,9 @@ GLSLANG_BRANCH := master<br> GLSLANG_GITURL := <a href="https://github.com/KhronosGroup/glslang.git">https://github.com/KhronosGroup/glslang.git</a><br> GLSLANG_BASENAME := $(subst .,_,$(subst \,_,$(subst /,_,$(GLSLANG_HASH))))<br> <br>+ifndef HAVE_WINSTORE<br> PKGS += glslang<br>+endif<br> ifeq ($(call need_pkg,"glslang"),)<br> PKGS_FOUND += glslang<br> endif<br>diff --git a/contrib/src/mfx/rules.mak b/contrib/src/mfx/rules.mak<br>index 2b4fbad702..1a5bba2233 100644<br>--- a/contrib/src/mfx/rules.mak<br>+++ b/contrib/src/mfx/rules.mak<br>@@ -7,8 +7,10 @@ ifeq ($(call need_pkg,"mfx"),)<br> PKGS_FOUND += mfx<br> endif<br> ifdef HAVE_WIN32<br>+ifndef HAVE_WINSTORE<br> PKGS += mfx<br> endif<br>+endif<br> <br> $(TARBALLS)/mfx-$(MFX_GITHASH).tar.xz:<br> $(call download_git,$(mfx_GITURL),,$(MFX_GITHASH))<br>diff --git a/contrib/src/modplug/rules.mak b/contrib/src/modplug/rules.mak<br>index 29507574e1..5e5fd421c3 100644<br>--- a/contrib/src/modplug/rules.mak<br>+++ b/contrib/src/modplug/rules.mak<br>@@ -3,7 +3,9 @@<br> MODPLUG_VERSION := 0.8.8.5<br> MODPLUG_URL := $(SF)/modplug-xmms/libmodplug-$(MODPLUG_VERSION).tar.gz<br> <br>+ifndef HAVE_WINSTORE<br> PKGS += modplug<br>+endif<br> ifeq ($(call need_pkg,"libmodplug >= 0.8.8.5"),)<br> PKGS_FOUND += modplug<br> endif<br>diff --git a/contrib/src/projectM/rules.mak b/contrib/src/projectM/rules.mak<br>index 24f3bdc9b0..29c92fd9f5 100644<br>--- a/contrib/src/projectM/rules.mak<br>+++ b/contrib/src/projectM/rules.mak<br>@@ -5,10 +5,12 @@ PROJECTM_URL := $(SF)/projectm/$(PROJECTM_VERSION)/projectM-$(PROJECTM_VERSION)-<br> ifdef HAVE_WIN32<br> ifneq ($(ARCH),arm)<br> ifneq ($(ARCH),aarch64)<br>+ifndef HAVE_WINSTORE<br> PKGS += projectM<br> endif<br> endif<br> endif<br>+endif<br> ifeq ($(call need_pkg,"libprojectM"),)<br> PKGS_FOUND += projectM<br> endif<br>diff --git a/contrib/src/qt/rules.mak b/contrib/src/qt/rules.mak<br>index d579b5d47b..b78b9169c3 100644<br>--- a/contrib/src/qt/rules.mak<br>+++ b/contrib/src/qt/rules.mak<br>@@ -10,8 +10,10 @@ ifdef HAVE_MACOSX<br> #PKGS += qt<br> endif<br> ifdef HAVE_WIN32<br>+ifndef HAVE_WINSTORE<br> PKGS += qt<br> endif<br>+endif<br> <br> ifeq ($(call need_pkg,"Qt5Core Qt5Gui Qt5Widgets"),)<br> PKGS_FOUND += qt<br>diff --git a/contrib/src/qtdeclarative/rules.mak b/contrib/src/qtdeclarative/rules.mak<br>index 817ec82874..36872c3330 100644<br>--- a/contrib/src/qtdeclarative/rules.mak<br>+++ b/contrib/src/qtdeclarative/rules.mak<br>@@ -6,6 +6,7 @@ QTDECLARATIVE_URL := <a href="http://download.qt.io/official_releases/qt/5.11/$(QTDECLARA">http://download.qt.io/official_releases/qt/5.11/$(QTDECLARA</a><br> DEPS_qtdeclarative += qt $(DEPS_qt)<br> <br> ifdef HAVE_WIN32<br>+ifndef HAVE_WINSTORE<br> ifeq ($(findstring $(ARCH), arm aarch64),)<br> # There is no opengl available on windows on these architectures.<br> # QtDeclarative in itself should be usable without opengl though, but<br>@@ -14,6 +15,7 @@ ifeq ($(findstring $(ARCH), arm aarch64),)<br> PKGS += qtdeclarative<br> endif<br> endif<br>+endif<br> <br> ifeq ($(call need_pkg,"Qt5Quick"),)<br> PKGS_FOUND += qtdeclarative<br>diff --git a/contrib/src/qtgraphicaleffects/rules.mak b/contrib/src/qtgraphicaleffects/rules.mak<br>index 669265fc9b..46175d1c4a 100644<br>--- a/contrib/src/qtgraphicaleffects/rules.mak<br>+++ b/contrib/src/qtgraphicaleffects/rules.mak<br>@@ -6,11 +6,13 @@ QTGE_URL := <a href="http://download.qt.io/official_releases/qt/5.11/$(QTGE_VERSION)/subm">http://download.qt.io/official_releases/qt/5.11/$(QTGE_VERSION)/subm</a><br> DEPS_qtgraphicaleffects += qtdeclarative $(DEPS_qtdeclarative)<br> <br> ifdef HAVE_WIN32<br>+ifndef HAVE_WINSTORE<br> ifeq ($(findstring $(ARCH), arm aarch64),)<br> # There is no opengl available on windows on these architectures.<br> PKGS += qtgraphicaleffects<br> endif<br> endif<br>+endif<br> <br> ifeq ($(call need_pkg,"Qt5QuickControls2"),)<br> PKGS_FOUND += qtgraphicaleffects<br>diff --git a/contrib/src/qtquickcontrols2/rules.mak b/contrib/src/qtquickcontrols2/rules.mak<br>index cff4aaf767..029e44fdb8 100644<br>--- a/contrib/src/qtquickcontrols2/rules.mak<br>+++ b/contrib/src/qtquickcontrols2/rules.mak<br>@@ -4,11 +4,13 @@ QTQC2_VERSION := 5.11.0<br> QTQC2_URL := <a href="http://download.qt.io/official_releases/qt/5.11/$(QTQC2_VERSION)/submodules/qtquickcontrols2-everywhere-src-$(QTQC2_VERSION).tar.xz">http://download.qt.io/official_releases/qt/5.11/$(QTQC2_VERSION)/submodules/qtquickcontrols2-everywhere-src-$(QTQC2_VERSION).tar.xz</a><br> <br> ifdef HAVE_WIN32<br>+ifndef HAVE_WINSTORE<br> ifeq ($(findstring $(ARCH), arm aarch64),)<br> # There is no opengl available on windows on these architectures.<br> PKGS += qtquickcontrols2<br> endif<br> endif<br>+endif<br> <br> ifeq ($(call need_pkg,"Qt5QuickControls2"),)<br> PKGS_FOUND += qtquickcontrols2<br>diff --git a/contrib/src/qtsvg/rules.mak b/contrib/src/qtsvg/rules.mak<br>index 9784b51ffd..2793cfd858 100644<br>--- a/contrib/src/qtsvg/rules.mak<br>+++ b/contrib/src/qtsvg/rules.mak<br>@@ -6,8 +6,10 @@ QTSVG_URL := <a href="https://download.qt.io/official_releases/qt/5.11/$(QTSVG_VERSION)/s">https://download.qt.io/official_releases/qt/5.11/$(QTSVG_VERSION)/s</a><br> DEPS_qtsvg += qt $(DEPS_qt)<br> <br> ifdef HAVE_WIN32<br>+ifndef HAVE_WINSTORE<br> PKGS += qtsvg<br> endif<br>+endif<br> <br> ifeq ($(call need_pkg,"Qt5Svg"),)<br> PKGS_FOUND += qtsvg<br>diff --git a/contrib/src/sdl/rules.mak b/contrib/src/sdl/rules.mak<br>index 4a933b5486..8eb56be0cc 100644<br>--- a/contrib/src/sdl/rules.mak<br>+++ b/contrib/src/sdl/rules.mak<br>@@ -3,7 +3,9 @@<br> SDL_VERSION := 1.2.15<br> SDL_URL := <a href="http://www.libsdl.org/release/SDL-$(SDL_VERSION).tar.gz">http://www.libsdl.org/release/SDL-$(SDL_VERSION).tar.gz</a><br> <br>+ifndef HAVE_WINSTORE<br> #PKGS += sdl<br>+endif<br> ifeq ($(call need_pkg,"sdl"),)<br> PKGS_FOUND += sdl<br> endif<br>diff --git a/contrib/src/srt/rules.mak b/contrib/src/srt/rules.mak<br>index c9dbb59db8..343dc44a55 100644<br>--- a/contrib/src/srt/rules.mak<br>+++ b/contrib/src/srt/rules.mak<br>@@ -4,8 +4,10 @@ SRT_VERSION := 1.3.1<br> SRT_URL := $(GITHUB)/Haivision/srt/archive/v$(SRT_VERSION).tar.gz<br> <br> ifdef BUILD_NETWORK<br>+ifndef HAVE_WINSTORE<br> PKGS += srt<br> endif<br>+endif<br> <br> ifeq ($(call need_pkg,"srt >= 1.3.1"),)<br> PKGS_FOUND += srt<br>diff --git a/contrib/src/vncclient/rules.mak b/contrib/src/vncclient/rules.mak<br>index e048fd68e0..20af67cbcb 100644<br>--- a/contrib/src/vncclient/rules.mak<br>+++ b/contrib/src/vncclient/rules.mak<br>@@ -4,8 +4,10 @@ VNCCLIENT_VERSION := 0.9.10<br> VNCCLIENT_URL := <a href="https://github.com/LibVNC/libvncserver/archive/LibVNCServer-$(VNCCLIENT_VERSION).tar.gz">https://github.com/LibVNC/libvncserver/archive/LibVNCServer-$(VNCCLIENT_VERSION).tar.gz</a><br> <br> ifdef BUILD_NETWORK<br>+ifndef HAVE_WINSTORE<br> PKGS += vncclient<br> endif<br>+endif<br> ifeq ($(call need_pkg,"libvncclient"),)<br> PKGS_FOUND += vncclient<br> endif</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>