<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hello all,<div class=""><br class=""></div><div class="">If nobody objects now, I’ll revert for now this as it breaks the UI.</div><div class="">And I do not want to block possible git bisects for too long if not needed.</div><div class=""><br class=""></div><div class="">Best regards,</div><div class="">David</div><div class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">Am 16.03.2019 um 21:35 schrieb David Fuhrmann <<a href="mailto:david.fuhrmann@gmail.com" class="">david.fuhrmann@gmail.com</a>>:</div><br class="Apple-interchange-newline"><div class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">Am 15.03.2019 um 11:19 schrieb Felix Paul Kühne <<a href="mailto:git@videolan.org" class="">git@videolan.org</a>>:<br class=""><br class="">vlc | branch: master | Felix Paul Kühne <<a href="mailto:felix@feepk.net" class="">felix@feepk.net</a>> | Fri Mar 15 11:12:56 2019 +0100| [224b04306d8c6629c0c905fd7ed2bacef65fa7d3] | committer: Felix Paul Kühne<br class=""><br class="">macosx: clean access to the aout/vout threads<br class=""><br class="">Use instance variables more effectively to save selector dispatches (and characters)<br class=""><br class=""><blockquote type="cite" class=""><a href="http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=224b04306d8c6629c0c905fd7ed2bacef65fa7d3" class="">http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=224b04306d8c6629c0c905fd7ed2bacef65fa7d3</a><br class=""></blockquote>---<br class=""><br class="">.../macosx/coreinteraction/VLCCoreInteraction.m | 26 ++++++++--------<br class="">modules/gui/macosx/menus/VLCMainMenu.m | 14 ++++-----<br class="">.../panels/VLCAudioEffectsWindowController.m | 36 +++++++++++++---------<br class="">.../panels/VLCVideoEffectsWindowController.m | 6 ++--<br class="">4 files changed, 46 insertions(+), 36 deletions(-)<br class=""><br class="">diff --git a/modules/gui/macosx/coreinteraction/VLCCoreInteraction.m b/modules/gui/macosx/coreinteraction/VLCCoreInteraction.m<br class="">index 85fb334939..0ec106ef3c 100644<br class="">--- a/modules/gui/macosx/coreinteraction/VLCCoreInteraction.m<br class="">+++ b/modules/gui/macosx/coreinteraction/VLCCoreInteraction.m<br class="">@@ -61,6 +61,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class=""><br class=""> VLCClickerManager *_clickerManager;<br class=""> VLCPlaylistController *_playlistController;<br class="">+ VLCPlayerController *_playerController;<br class="">}<br class="">@end<br class=""><br class="">@@ -94,6 +95,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class=""><br class=""> _clickerManager = [[VLCClickerManager alloc] init];<br class=""> _playlistController = [[VLCMain sharedInstance] playlistController];<br class="">+ _playerController = [_playlistController playerController];<br class=""><br class=""> var_AddCallback(pl_Get(p_intf), "intf-boss", BossCallback, (__bridge void *)self);<br class=""> }<br class="">@@ -119,18 +121,16 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class=""><br class="">- (void)playOrPause<br class="">{<br class="">- VLCMain *mainInstance = [VLCMain sharedInstance];<br class="">- VLCPlaylistController *playlistController = mainInstance.playlistController;<br class="">- input_item_t *p_input_item = playlistController.currentlyPlayingInputItem;<br class="">+ input_item_t *p_input_item = _playlistController.currentlyPlayingInputItem;<br class=""><br class=""> if (p_input_item) {<br class="">- [playlistController.playerController togglePlayPause];<br class="">+ [_playerController togglePlayPause];<br class=""> input_item_Release(p_input_item);<br class=""> } else {<br class="">- if (mainInstance.playlistController.playlistModel.numberOfPlaylistItems == 0)<br class="">- [[mainInstance open] openFileGeneric];<br class="">+ if (_playlistController.playlistModel.numberOfPlaylistItems == 0)<br class="">+ [[[VLCMain sharedInstance] open] openFileGeneric];<br class=""> else<br class="">- [playlistController startPlaylist];<br class="">+ [_playlistController startPlaylist];<br class=""> }<br class="">}<br class=""><br class="">@@ -381,7 +381,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class=""> }<br class=""> config_PutInt("random", on);<br class=""><br class="">- vout_thread_t *p_vout = [[_playlistController playerController] mainVideoOutputThread];<br class="">+ vout_thread_t *p_vout = [_playerController mainVideoOutputThread];<br class=""> if (!p_vout) {<br class=""> return;<br class=""> }<br class="">@@ -398,7 +398,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class="">{<br class=""> _playlistController.playbackRepeat = VLC_PLAYLIST_PLAYBACK_REPEAT_ALL;<br class=""><br class="">- vout_thread_t *p_vout = [[_playlistController playerController] mainVideoOutputThread];<br class="">+ vout_thread_t *p_vout = [_playerController mainVideoOutputThread];<br class=""> if (p_vout) {<br class=""> vout_OSDMessage(p_vout, VOUT_SPU_CHANNEL_OSD, "%s", _("Repeat All"));<br class=""> vout_Release(p_vout);<br class="">@@ -409,7 +409,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class="">{<br class=""> _playlistController.playbackRepeat = VLC_PLAYLIST_PLAYBACK_REPEAT_CURRENT;<br class=""><br class="">- vout_thread_t *p_vout = [[_playlistController playerController] mainVideoOutputThread];<br class="">+ vout_thread_t *p_vout = [_playerController mainVideoOutputThread];<br class=""> if (p_vout) {<br class=""> vout_OSDMessage(p_vout, VOUT_SPU_CHANNEL_OSD, "%s", _("Repeat One"));<br class=""> vout_Release(p_vout);<br class="">@@ -420,7 +420,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class="">{<br class=""> _playlistController.playbackRepeat = VLC_PLAYLIST_PLAYBACK_REPEAT_NONE;<br class=""><br class="">- vout_thread_t *p_vout = [[_playlistController playerController] mainVideoOutputThread];<br class="">+ vout_thread_t *p_vout = [_playerController mainVideoOutputThread];<br class=""> if (p_vout) {<br class=""> vout_OSDMessage(p_vout, VOUT_SPU_CHANNEL_OSD, "%s", _("Repeat Off"));<br class=""> vout_Release(p_vout);<br class="">@@ -574,7 +574,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class=""><br class="">- (void)showPosition<br class="">{<br class="">- vout_thread_t *p_vout = [[_playlistController playerController] mainVideoOutputThread];<br class="">+ vout_thread_t *p_vout = [_playerController mainVideoOutputThread];<br class=""> if (p_vout != NULL) {<br class=""> var_SetInteger(vlc_object_instance(getIntf()), "key-action", ACTIONID_POSITION);<br class=""> vout_Release(p_vout);<br class="">@@ -678,7 +678,7 @@ static int BossCallback(vlc_object_t *p_this, const char *psz_var,<br class=""> unichar key = [characters characterAtIndex: 0];<br class=""><br class=""> if (key) {<br class="">- vout_thread_t *p_vout = [[_playlistController playerController] mainVideoOutputThread];<br class="">+ vout_thread_t *p_vout = [_playerController mainVideoOutputThread];<br class=""> if (p_vout != NULL) {<br class=""> /* Escape */<br class=""> if (key == (unichar) 0x1b) {<br class="">diff --git a/modules/gui/macosx/menus/VLCMainMenu.m b/modules/gui/macosx/menus/VLCMainMenu.m<br class="">index 5f91103146..41359c320f 100644<br class="">--- a/modules/gui/macosx/menus/VLCMainMenu.m<br class="">+++ b/modules/gui/macosx/menus/VLCMainMenu.m<br class="">@@ -585,7 +585,7 @@<br class=""> [self setupVarMenuItem:_subtitle_track target: (vlc_object_t *)p_input<br class=""> var:"spu-es" selector: @selector(toggleVar:)];<br class=""><br class="">- audio_output_t *p_aout = _playlistController.playerController.mainAudioOutput;<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout != NULL) {<br class=""> [self setupVarMenuItem:_channels target: (vlc_object_t *)p_aout<br class=""> var:"stereo-mode" selector: @selector(toggleVar:)];<br class="">@@ -595,7 +595,7 @@<br class=""> aout_Release(p_aout);<br class=""> }<br class=""><br class="">- vout_thread_t *p_vout = [[[[VLCMain sharedInstance] playlistController] playerController] videoOutputThreadForKeyWindow];<br class="">+ vout_thread_t *p_vout = [_playerController videoOutputThreadForKeyWindow];<br class=""><br class=""> if (p_vout != NULL) {<br class=""> [self setupVarMenuItem:_aspect_ratio target: (vlc_object_t *)p_vout<br class="">@@ -886,7 +886,7 @@<br class=""><br class=""> [_audioDeviceMenu removeAllItems];<br class=""><br class="">- audio_output_t *p_aout = _playlistController.playerController.mainAudioOutput;<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (!p_aout)<br class=""> return;<br class=""><br class="">@@ -923,7 +923,7 @@<br class=""><br class="">- (void)toggleAudioDevice:(id)sender<br class="">{<br class="">- audio_output_t *p_aout = _playlistController.playerController.mainAudioOutput;<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (!p_aout)<br class=""> return;<br class=""><br class="">@@ -950,7 +950,7 @@<br class=""><br class="">- (IBAction)resizeVideoWindow:(id)sender<br class="">{<br class="">- vout_thread_t *p_vout = [[[[VLCMain sharedInstance] playlistController] playerController] videoOutputThreadForKeyWindow];<br class="">+ vout_thread_t *p_vout = [_playerController videoOutputThreadForKeyWindow];<br class=""> if (p_vout) {<br class=""> if (sender == _half_window)<br class=""> var_SetFloat(p_vout, "zoom", 0.5);<br class="">@@ -971,7 +971,7 @@<br class=""> // FIXME re-write using VLCPlayerController<br class=""> input_thread_t *p_input = pl_CurrentInput(getIntf());<br class=""> if (p_input) {<br class="">- vout_thread_t *p_vout = [[[[VLCMain sharedInstance] playlistController] playerController] videoOutputThreadForKeyWindow];<br class="">+ vout_thread_t *p_vout = [_playerController videoOutputThreadForKeyWindow];<br class=""> if (p_vout) {<br class=""> BOOL b_fs = var_ToggleBool(p_vout, "video-on-top");<br class=""> var_SetBool(pl_Get(getIntf()), "video-on-top", b_fs);<br class="">@@ -1664,7 +1664,7 @@<br class=""> mi == _floatontop<br class=""> ) {<br class=""><br class="">- vout_thread_t *p_vout = [[[[VLCMain sharedInstance] playlistController] playerController] videoOutputThreadForKeyWindow];<br class="">+ vout_thread_t *p_vout = [_playerController videoOutputThreadForKeyWindow];<br class=""> if (p_vout != NULL) {<br class=""> // FIXME: re-write using VLCPlayerController<br class=""> if (mi == _floatontop)<br class="">diff --git a/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m b/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m<br class="">index 87ee801b92..010ca22df5 100644<br class="">--- a/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m<br class="">+++ b/modules/gui/macosx/panels/VLCAudioEffectsWindowController.m<br class="">@@ -41,6 +41,11 @@<br class="">#import "playlist/VLCPlaylistController.h"<br class="">#import "playlist/VLCPlayerController.h"<br class=""><br class="">+@interface VLCAudioEffectsWindowController ()<br class="">+{<br class="">+ VLCPlayerController *_playerController;<br class="">+}<br class="">+@end<br class=""><br class="">#pragma mark -<br class="">#pragma mark Initialization<br class="">@@ -96,6 +101,8 @@<br class="">{<br class=""> self = [super initWithWindowNibName:@"AudioEffects"];<br class=""> if (self) {<br class="">+ _playerController = [[[VLCMain sharedInstance] playlistController] playerController];<br class="">+<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Hi Felix,</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Does this actually works for you?</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On my machine, now VLC immediately crashes at startup like that:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Crashed Thread: 0 Dispatch queue: com.apple.main-thread</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Exception Type: EXC_BAD_INSTRUCTION (SIGILL)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Exception Codes: 0x0000000000000001, 0x0000000000000000</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Exception Note: EXC_CORPSE_NOTIFY</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Termination Signal: Illegal instruction: 4</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Termination Reason: Namespace SIGNAL, Code 0x4</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Terminating Process: exc handler [6895]</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Application Specific Information:</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">BUG IN CLIENT OF LIBDISPATCH: trying to lock recursively</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Thread 0 Crashed:: Dispatch queue: com.apple.main-thread</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0 libdispatch.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00007fff7c0c08c3 _dispatch_once_wait + 97</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">1 libmacosx_plugin.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00000001068f2be4 +[VLCMain sharedInstance] + 84 (once.h:85)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">2 libmacosx_plugin.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x000000010691a590 -[VLCAudioEffectsWindowController init] + 128 (VLCAudioEffectsWindowController.m:104)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">3 libmacosx_plugin.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00000001068f30a9 -[VLCMain init] + 1033</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">4 libmacosx_plugin.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00000001068f2c44 __25+[VLCMain sharedInstance]_block_invoke + 52 (VLCMain.m:211)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">5 libdispatch.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00007fff7c0bfdcf _dispatch_client_callout + 8</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">6 libdispatch.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00007fff7c0c1515 _dispatch_once_callout + 20</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">7 libmacosx_plugin.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00000001068f2be4 +[VLCMain sharedInstance] + 84 (once.h:85)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">8 libmacosx_plugin.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00000001068f2788 OpenIntf + 184 (VLCMain.m:105)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">9 libvlccore.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x000000010668573b generic_start + 139 (modules.c:258)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">10 libvlccore.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00000001066853e6 module_load + 166</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">11 libvlccore.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x0000000106684fce vlc_module_load + 958 (modules.c:194)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">12 libvlccore.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x000000010668563b module_need + 91 (modules.c:277)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">13 libvlccore.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x000000010668f88e intf_CreateInternal + 782 (interface.c:193)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">14 libvlccore.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x000000010668fd41 libvlc_InternalAddIntf + 257 (interface.c:297)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">15 libvlc.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x0000000106629ef0 libvlc_add_intf + 32 (playlist.c:43)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">16 org.videolan.vlc </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x000000010661e667 main + 1767 (darwinvlc.m:285)</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">17 libdyld.dylib </span><span class="Apple-tab-span" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: pre; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"> </span><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">0x00007fff7c10ded9 start + 1</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">BR. David</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""> self.popupPanel = [[VLCPopupPanelController alloc] init];<br class=""> self.textfieldPanel = [[VLCTextfieldPanelController alloc] init];<br class=""><br class="">@@ -153,7 +160,7 @@<br class=""><br class=""> /* eq preset */<br class=""> char const *psz_eq_preset = [B64DecNSStr([items firstObject]) UTF8String];<br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout)<br class=""> var_SetString(p_aout, "equalizer-preset", psz_eq_preset);<br class=""> var_SetString(p_playlist, "equalizer-preset", psz_eq_preset);<br class="">@@ -609,10 +616,11 @@<br class="">#pragma mark -<br class="">#pragma mark Equalizer<br class="">static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class="">+ VLCPlayerController *playerController,<br class=""> char *psz_name)<br class="">{<br class=""> char *psz_parser, *psz_string = NULL;<br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [playerController mainAudioOutput];<br class=""> if (!p_aout)<br class=""> return false;<br class=""><br class="">@@ -654,7 +662,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""> [[_equalizerPresetsPopup lastItem] setAction: @selector(deletePresetAction:)];<br class=""> }<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""><br class=""> NSString *currentPreset = nil;<br class=""> if (p_aout) {<br class="">@@ -684,7 +692,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""> intf_thread_t *p_intf = getIntf();<br class=""> playlist_t *p_playlist = pl_Get(p_intf);<br class=""> bool b_2p = var_CreateGetBool(p_playlist, "equalizer-2pass");<br class="">- bool bEnabled = GetEqualizerStatus(p_intf, (char *)"equalizer");<br class="">+ bool bEnabled = GetEqualizerStatus(p_intf, _playerController, (char *)"equalizer");<br class=""><br class=""> /* Setup sliders */<br class=""> var_Create(p_playlist, "equalizer-preset",<br class="">@@ -758,7 +766,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""><br class="">- (IBAction)equalizerBandSliderUpdated:(id)sender<br class="">{<br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> char const *psz_preset_values = [[self generatePresetString] UTF8String];<br class=""> if (p_aout) {<br class=""> var_SetString(p_aout, "equalizer-bands", psz_preset_values);<br class="">@@ -776,7 +784,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""> float f_eq_preamp = [[[defaults objectForKey:@"EQPreampValues"] objectAtIndex:numberOfChosenPreset] floatValue];<br class=""> char const *psz_eq_preset = [[[defaults objectForKey:@"EQNames"] objectAtIndex:numberOfChosenPreset] UTF8String];<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetString(p_aout, "equalizer-bands", psz_eq_bands);<br class=""> var_SetFloat(p_aout, "equalizer-preamp", f_eq_preamp);<br class="">@@ -796,7 +804,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class="">{<br class=""> float fPreamp = [sender floatValue] ;<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetFloat(p_aout, "equalizer-preamp", fPreamp);<br class=""> aout_Release(p_aout);<br class="">@@ -808,7 +816,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class="">{<br class=""> bool b_2p = [sender state] ? true : false;<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetBool(p_aout, "equalizer-2pass", b_2p);<br class=""> aout_Release(p_aout);<br class="">@@ -850,7 +858,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""><br class=""> /* update VLC internals */<br class=""> char const *psz_eq_preset = [decomposedStringWithCanonicalMapping UTF8String];<br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [self->_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetString(p_aout, "equalizer-preset", psz_eq_preset);<br class=""> aout_Release(p_aout);<br class="">@@ -943,7 +951,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""> var_SetFloat(p_playlist, "compressor-knee", 2.500000);<br class=""> var_SetFloat(p_playlist, "compressor-makeup-gain", 7.000000);<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetFloat(p_aout, "compressor-rms-peak", 0.000000);<br class=""> var_SetFloat(p_aout, "compressor-attack", 25.000000);<br class="">@@ -985,7 +993,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""><br class=""> assert(psz_property);<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetFloat(p_aout, psz_property, f_value);<br class=""> aout_Release(p_aout);<br class="">@@ -1047,7 +1055,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""> var_SetFloat(p_playlist, "spatializer-dry", .5);<br class=""> var_SetFloat(p_playlist, "spatializer-damp", .5);<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetFloat(p_aout, "spatializer-roomsize", .85);<br class=""> var_SetFloat(p_aout, "spatializer-width", 1.);<br class="">@@ -1083,7 +1091,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""><br class=""> assert(psz_property);<br class=""><br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> if (p_aout) {<br class=""> var_SetFloat(p_aout, psz_property, f_value / 10.f);<br class=""> aout_Release(p_aout);<br class="">@@ -1145,7 +1153,7 @@ static bool GetEqualizerStatus(intf_thread_t *p_custom_intf,<br class=""><br class="">- (IBAction)filterVolumeNormSliderUpdated:(id)sender<br class="">{<br class="">- audio_output_t *p_aout = [[[[VLCMain sharedInstance] playlistController] playerController] mainAudioOutput];<br class="">+ audio_output_t *p_aout = [_playerController mainAudioOutput];<br class=""> float f_value = [_filterNormLevelSlider floatValue];<br class=""><br class=""> if (p_aout) {<br class="">diff --git a/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m b/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m<br class="">index 3779afc949..6b2ad1a9a5 100644<br class="">--- a/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m<br class="">+++ b/modules/gui/macosx/panels/VLCVideoEffectsWindowController.m<br class="">@@ -115,21 +115,23 @@<br class=""><br class=""> /* enable the new filters */<br class=""> var_SetString(p_playlist, "video-filter", [tempString UTF8String]);<br class="">- if (vouts)<br class="">+ if (vouts) {<br class=""> for (NSValue *ptr in vouts) {<br class=""> vout_thread_t *p_vout = [ptr pointerValue];<br class=""> var_SetString(p_vout, "video-filter", [tempString UTF8String]);<br class=""> }<br class="">+ }<br class=""><br class=""> tempString = B64DecNSStr([items objectAtIndex:1]);<br class=""> /* enable another round of new filters */<br class=""> var_SetString(p_playlist, "sub-source", [tempString UTF8String]);<br class="">- if (vouts)<br class="">+ if (vouts) {<br class=""> for (NSValue *ptr in vouts) {<br class=""> vout_thread_t *p_vout = [ptr pointerValue];<br class=""> var_SetString(p_vout, "sub-source", [tempString UTF8String]);<br class=""> vout_Release(p_vout);<br class=""> }<br class="">+ }<br class=""><br class=""> tempString = B64DecNSStr([items objectAtIndex:2]);<br class=""> /* enable another round of new filters */<br class=""><br class="">_______________________________________________<br class="">vlc-commits mailing list<br class=""><a href="mailto:vlc-commits@videolan.org" class="">vlc-commits@videolan.org</a><br class="">https://mailman.videolan.org/listinfo/vlc-commits</blockquote></div></blockquote></div><br class=""></div></body></html>