<html><head></head><body>It is safer to put things in config.h because that's tracked by dependency propagation, can have order adjusted easily and does not extend the command line in unreasonable.<br><br>+ Arguments already made.<br><br>If you don't revert this, I'll have to raise it to the ctte.<br><br><div class="gmail_quote">Le 20 mars 2019 00:02:36 GMT+08:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 3/19/2019 4:29 PM, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">Le mardi 19 mars 2019, 17:12:04 EET Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;">On 3/19/2019 3:01 PM, Rémi Denis-Courmont wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;">Le mardi 19 mars 2019, 12:50:50 EET Steve Lhomme a écrit :<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"> vlc | branch: master | Steve Lhomme <robux4@ycbcr.xyz> | Wed Mar 13<br> 15:51:28 2019 +0100| [277b45efff01dcccd42f1e4943aa09297f99650e] |<br> committer: Steve Lhomme<br><br> configure: use WINSTORECOMPAT when building for Windows Store<br><br> We may use some forbidden APIs that are actually usable via<br> WindowsStoreCompat<br></blockquote>This is wrong. Please revert.<br></blockquote>It's not *wrong*. That's not the way you would do it. But IMO it's safer<br>that way for reasons already given.<br></blockquote>It is wrong because that's not the way our chosen (autoconf in this case)<br>build system does it, and inconsistent with the rest of the code base.<br></blockquote><br>I see plenty of -D in configure.ac (not including the ones for some <br>modules).<br><br>AH_TOP and AH_BOTTOM have been giving issues when building for Windows <br>already and many have been removed because of that. There's no reason to <br>go back that way.<br><br>And of course the forced linking cannot be added through AH_*<br><br>As for _GNU_SOURCE you mentioned in your review, it's coming from <br>AC_USE_SYSTEM_EXTENSIONS and it's using AC_DEFINE and AC_VERBATIM. But <br>there's no guarantee that config.h is included in every file and <br>included before any windows header. So it's safer to define it via the <br>compiler.<br><br>><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> But obviously your niche Windows platform is so much important than all others<br> (incl. desktop Windows) that it deserves its own hacks for the alleged sake of<br> "safety".<br><br> -- <br> Rémi Denis-Courmont<hr> vlc-devel mailing list<br> To unsubscribe or modify your subscription options:<br> <a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a><br></blockquote><hr>vlc-devel mailing list<br>To unsubscribe or modify your subscription options:<br><a href="https://mailman.videolan.org/listinfo/vlc-devel">https://mailman.videolan.org/listinfo/vlc-devel</a></pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>