<div dir="ltr"><div>My bad, it is allowing both<br></div><div><br></div><div>The warning with the /* fallthrough */ I saw was actually being caused by a macro expansion into multiple empty case: lines<br></div><div><br></div><div>Apologies<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 22, 2019 at 2:06 PM Steve Lhomme <<a href="mailto:robux4@ycbcr.xyz">robux4@ycbcr.xyz</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 3/22/2019 9:36 AM, Awais Chishti wrote:<br>
> Hi,<br>
> Turns out a more portable way is to replace /* fallthrough */ with /* <br>
> fall through */.<br>
<br>
We already use that in many places. I thought it allowed both variants. <br>
Did it change or was I wrong ?<br>
<br>
> This should work will older versions of GCC and Clang as well.<br>
> I'll send a different patch.<br>
><br>
> On Fri, Mar 22, 2019 at 1:11 PM Awais Chishti <br>
> <<a href="mailto:chishtiawais511@gmail.com" target="_blank">chishtiawais511@gmail.com</a> <mailto:<a href="mailto:chishtiawais511@gmail.com" target="_blank">chishtiawais511@gmail.com</a>>> wrote:<br>
><br>
>     I'll look into it right now. Thanks.<br>
><br>
>     On Fri, Mar 22, 2019 at 1:09 PM Steve Lhomme <<a href="mailto:robux4@ycbcr.xyz" target="_blank">robux4@ycbcr.xyz</a><br>
>     <mailto:<a href="mailto:robux4@ycbcr.xyz" target="_blank">robux4@ycbcr.xyz</a>>> wrote:<br>
><br>
>         Hi,<br>
><br>
>          From a quick look it seems that this attribute was added in<br>
>         gcc 7 but<br>
>         we support older versions of gcc. So you need to check the gcc<br>
>         version.<br>
><br>
>         Also you may need to check if it works with Clang as well and<br>
>         since what<br>
>         version.<br>
><br>
>         On 3/21/2019 8:10 PM, <a href="mailto:chishtiawais511@gmail.com" target="_blank">chishtiawais511@gmail.com</a><br>
>         <mailto:<a href="mailto:chishtiawais511@gmail.com" target="_blank">chishtiawais511@gmail.com</a>> wrote:<br>
>         > From: Awais Chishti <<a href="mailto:chishtiawais511@gmail.com" target="_blank">chishtiawais511@gmail.com</a><br>
>         <mailto:<a href="mailto:chishtiawais511@gmail.com" target="_blank">chishtiawais511@gmail.com</a>>><br>
>         ><br>
>         > ---<br>
>         >   include/vlc_common.h | 13 +++++++++++++<br>
>         >   1 file changed, 13 insertions(+)<br>
>         ><br>
>         > diff --git a/include/vlc_common.h b/include/vlc_common.h<br>
>         > index 033c618677..f3eb10271a 100644<br>
>         > --- a/include/vlc_common.h<br>
>         > +++ b/include/vlc_common.h<br>
>         > @@ -185,6 +185,19 @@<br>
>         >   # define VLC_USED<br>
>         >   #endif<br>
>         ><br>
>         > +/**<br>
>         > + * Explicitly indicate fallthrough<br>
>         > + *<br>
>         > + * Use this macro as a replacement for //fallthrough<br>
>         comments in switch blocks.<br>
>         > + *<br>
>         > + * This may disable inaccurate compiler warnings of<br>
>         implicit fallthrough.<br>
>         > + */<br>
>         > +#ifdef __GNUC__<br>
>         > +# define VLC_FALLTHROUGH __attribute__ ((fallthrough));<br>
>         > +#else<br>
>         > +# define VLC_FALLTHROUGH<br>
>         > +#endif<br>
>         > +<br>
>         >   #if defined (__ELF__) || defined (__MACH__)<br>
>         >   # define VLC_WEAK __attribute__((weak))<br>
>         >   #else<br>
>         > --<br>
>         > 2.21.0<br>
>         ><br>
>         > _______________________________________________<br>
>         > vlc-devel mailing list<br>
>         > To unsubscribe or modify your subscription options:<br>
>         > <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
><br>
>         _______________________________________________<br>
>         vlc-devel mailing list<br>
>         To unsubscribe or modify your subscription options:<br>
>         <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
><br>
><br>
> _______________________________________________<br>
> vlc-devel mailing list<br>
> To unsubscribe or modify your subscription options:<br>
> <a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a><br>
<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/vlc-devel</a></blockquote></div>