<HTML><BODY><p style='margin-top: 0px;' dir="ltr">Can someone please revisit this patch? The problem it solves is crashing important features. Some discussion was done earlier but there was no final decision.</p>
Thursday, 21 March 2019, 08:08PM +05:00 from Francois Cartegnie <a href="mailto:fcartegnie@gmail.com">fcartegnie@gmail.com</a>:<br><br><blockquote id="mail-app-auto-quote" style="border-left:1px solid #FC2C38; margin:0px 0px 0px 10px; padding:0px 0px 0px 10px;" cite="15531809320000000603">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div >
<base target="_self" href="https://e-aj.my.com/" />
<div id="style_15531809320000000603_BODY">Le 21/03/2019 à 16:20, Steve Lhomme a écrit :<br>
> I'd like Francois to clarify what he meant.<br>
> <br>
> On 3/21/2019 8:32 AM, Awais Chishti wrote:<br>
>> So, what do we do to fix it?<br>
>><br>
>> On Wed, Mar 20, 2019 at 7:58 PM Steve Lhomme <<a href="mailto:robux4@ycbcr.xyz">robux4@ycbcr.xyz</a><br>
>> <mailto:robux4@ycbcr.xyz>> wrote:<br>
>><br>
>> On 3/20/2019 3:51 PM, Thomas Guillem wrote:<br>
>> > I think you should set p_module and description to NULL for spu and<br>
>> > video like it's done for audio.<br>
>><br>
>> That's what the previous patch was doing. But IMO it's not correct.<br>
>> Although I don't understand what Francois is referring to.<br>
>><br>
>> It could be the decoder must be released before the rest of the<br>
>> *_clean() function is done, but I don't see anything in there that<br>
>> looks<br>
>> dubious.<br>
<br>
We copy fmt_in or fmt_out for info we need late, after the decoder chain<br>
is created in transcode test steps, after start/stopping the decoder/chain.<br>
<br>
This needs to be compared to behavior before transcode split/refactoring<br>
<br>
-- <br>
Francois Cartegnie<br>
VideoLAN - VLC Developer<br>
_______________________________________________<br>
vlc-devel mailing list<br>
To unsubscribe or modify your subscription options:<br>
<a href="https://mailman.videolan.org/listinfo/vlc-devel" target="_blank" >https://mailman.videolan.org/listinfo/vlc-devel</a></div>
<base target="_self" href="https://e-aj.my.com/" />
</div>
</div>
</blockquote></BODY></HTML>