<html><head></head><body>Hi,<br><br>It is not clear to me what the intended UX is here. If the goal is to be on top regardless of video status, then the current code is correct. If the goal is to be on top when there is a video embedded inside the GUI, then neither the current code nor the patch are really correct.<br><br><div class="gmail_quote">Le 27 mars 2019 08:59:31 GMT+02:00, Steve Lhomme <robux4@ycbcr.xyz> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">In that case the external video is the one that should be on top.<hr> modules/gui/qt/main_interface.cpp | 3 ++-<br> 1 file changed, 2 insertions(+), 1 deletion(-)<br><br>diff --git a/modules/gui/qt/main_interface.cpp b/modules/gui/qt/main_interface.cpp<br>index 82ce6e81a8..6f5c487304 100644<br>--- a/modules/gui/qt/main_interface.cpp<br>+++ b/modules/gui/qt/main_interface.cpp<br>@@ -148,7 +148,8 @@ MainInterface::MainInterface( intf_thread_t *_p_intf ) : QVLCMW( _p_intf ),<br> b_plDocked = getSettings()->value( "MainWindow/pl-dock-status", true ).toBool();<br> <br> /* Should the UI stays on top of other windows */<br>- b_interfaceOnTop = var_InheritBool( p_intf, "video-on-top" );<br>+ b_interfaceOnTop = var_InheritBool( p_intf, "video-on-top" ) &&<br>+ var_InheritBool( p_intf, "embedded-video" );<br> <br> #ifdef QT5_HAS_WAYLAND<br> b_hasWayland = QGuiApplication::platformName()</pre></blockquote></div><br>-- <br>Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.</body></html>